Consider only subsets, not permutations#4
Open
recmo wants to merge 1 commit into
Open
Conversation
Empirically, if a solution is satisfying, so are all its permutation. So it is sufficient to iterate over all subsets of length `NUM_CELLS` of the small range, which is much faster for larger sizes. Additionally, the iterator is not converted to a list (which leads to a combinatorial sized memory allocation).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empirically (in large fields), if a solution is satisfying then so are all its permutation and no valid solution has repeated elements. So it is sufficient to iterate over all subsets of length
NUM_CELLSof the small range, which is much faster for larger sizes.Additionally, the iterator is not converted to a list (which leads to a combinatorial sized memory allocation).
Note that the range is left hardcoded and will have to be increased for larger
NUM_CELLS.