Quick fix for automatic resizing on touch initiation#28
Open
guptashashvat wants to merge 1 commit intoHotStudio:masterfrom
Open
Quick fix for automatic resizing on touch initiation#28guptashashvat wants to merge 1 commit intoHotStudio:masterfrom
guptashashvat wants to merge 1 commit intoHotStudio:masterfrom
Conversation
On every touch initiation it takes data.scale as 1 due to which the image size unexpectedly changes if we aleady have some css transform values set up. The fix would be: For the very first time, transform with data.scale. And in rest of the cases set the scaling relative to previous scale values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On every touch initiation it takes data.scale as 1 due to which the image size unexpectedly changes if we aleady have some css transform values set up.
The fix would be: For the very first time, transform with data.scale. And in rest of the cases set the scaling relative to previous scale values.