Skip to content

Improve export scripts and small patches#24

Merged
kirbyh merged 13 commits into
mainfrom
ksh-patching
Dec 18, 2025
Merged

Improve export scripts and small patches#24
kirbyh merged 13 commits into
mainfrom
ksh-patching

Conversation

@kirbyh

@kirbyh kirbyh commented Dec 5, 2025

Copy link
Copy Markdown
Member

Improvements to utils/export.py to return a list of files to export (say, in a tarball)

Small bug fixes to BudgetIO.get_ustar() and other helper functions.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the export utilities to support creating file lists for tarball generation and fixes bugs in BudgetIO helper functions.

Key changes:

  • Extracts file listing logic into a new list_padeops_files() function that returns file paths instead of copying them
  • Adds print_files_stdout() function for command-line usage with tar
  • Implements the previously stubbed export_concurrent() function with basic command-line argument handling

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.

File Description
padeopsIO/utils/export.py Refactors copy_padeops_data to extract file listing logic into list_padeops_files, adds print_files_stdout helper, and implements basic CLI for export_concurrent
padeopsIO/budgetIO.py Adds query_logfile method, fixes parameter name in get_ustar call (from search_str to logfile), and updates documentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread padeopsIO/utils/export.py Outdated
Comment thread padeopsIO/budgetIO.py Outdated
Comment thread padeopsIO/budgetIO.py Outdated
Comment thread padeopsIO/utils/export.py Outdated
Comment thread padeopsIO/utils/export.py Outdated
Comment thread padeopsIO/budgetIO.py Outdated
Comment thread padeopsIO/utils/export.py Outdated
kirbyh and others added 7 commits December 5, 2025 12:48
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@kirbyh kirbyh merged commit 7ac41a0 into main Dec 18, 2025
30 checks passed
@kirbyh kirbyh deleted the ksh-patching branch December 18, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants