feat(engineer-brain): require Atlassian MCP Jira signal for sync

[Hrithik-Gavankar]

Require Atlassian MCP as plugin from cursor marketplace for sync

[tejas161]

Thanks for pushing Jira into the required sync path — the onboarding doc is exactly what was missing.

Requesting changes on a few items:

Blocking

1. docs/faq.md — markdown table is broken

The new Jira FAQ block is inserted inside the frequency table, so update, quarterly, and reflect render as stray rows. Move the "### How do I set up Jira for sync?" subsection below the completed table.

2. Onboarding links break after install.sh

install.sh copies skill/rule files into the user workspace but does not copy docs/engineer-brain-onboarding.md. Several links assume the brainstack repo layout:

File	Link	Resolves after install to
platforms/cursor/rules/engineer-brain.mdc	docs/engineer-brain-onboarding.md	<workspace>/docs/... (usually missing)
platforms/cursor/skills/engineer-brain/SKILL.md	../../../../docs/...	Parent of workspace (wrong)
core/COMMANDS.md (→ .engineer-brain/COMMANDS.md)	../docs/...	<workspace>/docs/... (usually missing)

Commit 952c78c fixes paths in the source tree, not the installed layout. Please either install the doc (e.g. copy to .cursor/skills/engineer-brain/ONBOARDING.md and link there), use stable GitHub URLs, or both.

3. docs/engineer-brain-onboarding.md — org-specific examples in a public repo

Several spots assume Red Hat / AAP / Ansible (e.g. hgavanka@redhat.com, redhat.atlassian.net, AAP-xxxxx, Ansible sprint note). Replace with placeholders (your-org.atlassian.net, PROJ-12345, you@company.com) and optionally add a short "Example (Red Hat)" callout.

4. Platform scope — core/COMMANDS.md vs Claude Code

core/COMMANDS.md now says Atlassian MCP is required for every sync, but the plugin is Cursor-only, platforms/claude-code/CLAUDE.md still documents only jira.sh, and install.sh does not copy jira.sh into .cursor/skills/engineer-brain/scripts/. Clarify Cursor vs other platforms and align adapters.

Should fix (non-blocking)

• Step order: Jira is 2b but Calendar is 2a in both SKILL.md and COMMANDS.md — renumber for readability.
• Sample JQL: Add copy-paste examples for the standup date window and note that searchJiraIssuesUsingJql needs cloudId from getAccessibleAtlassianResources.
• Status filter: status in ("In Progress", "In Review", "Review") may miss custom workflows; jira.sh active uses statusCategory = "In Progress" — consider aligning.
• doctor / platforms/cursor/README.md: Consider adding Atlassian MCP to prerequisites and health checks now that Jira is required.

What works well

• Clear "hard rule" + blocked standup state when MCP is missing (better than silently omitting Jira).
• Good onboarding structure (signals table, verify steps, troubleshooting).
• README / architecture cross-links improve discoverability.
• CLI fallback preserved for terminals/CI.

Suggested test plan

• Render docs/faq.md — frequency table intact; Jira subsection below it.
• Run bash install.sh cursor <test-workspace> — confirm onboarding links resolve from installed SKILL.md + engineer-brain.mdc.
• /engineer-brain sync with Atlassian plugin connected — Jira tickets in standup bullets.
• /engineer-brain sync with plugin disabled — standup shows Jira blocked + onboarding pointer.
• Monday sync — Friday-only window reflected in Jira JQL.

Happy to re-review once these are addressed.

[tejas161]

Re-reviewed after 268c0f6 — all previously blocking items are addressed. Approving.

Previously requested → status

Item	Status
FAQ table broken	✅ Fixed — Jira subsection moved below the completed table
Post-install links	✅ Fixed — install.sh copies ONBOARDING.md to .engineer-brain/ and .cursor/skills/engineer-brain/; SKILL.md + engineer-brain.mdc link the installed copy
Org-specific examples	✅ Fixed — generic placeholders + optional Red Hat callout
Platform scope (Cursor MCP vs jira.sh)	✅ Fixed — COMMANDS.md, architecture.md, CLAUDE.md, and install.sh now align; jira.sh shipped to all install paths
Step order / sample JQL / statusCategory	✅ Addressed — 2a calendar → 2b Jira; sample JQL + cloudId note; statusCategory aligned with jira.sh active
doctor + platforms/cursor/README.md	✅ Added — gh + JIRA_* checks and Atlassian MCP in prerequisites

Minor nits (non-blocking, optional follow-up)

1. team-brain-onboarding.md anchor — link still targets #step-3--atlassian-mcp-jira--required but the heading is now Step 3 — Jira signal (required) (anchor likely #step-3--jira-signal-required).
2. Duplicate source of truth — docs/engineer-brain-onboarding.md and platforms/cursor/skills/engineer-brain/ONBOARDING.md are identical; install.sh copies from docs/ only. Consider dropping the platforms copy or generating it at install time to avoid drift.
3. core/COMMANDS.md link text — [ONBOARDING.md](../docs/engineer-brain-onboarding.md) is confusing when installed (same-dir ONBOARDING.md exists). Prefer [ONBOARDING.md](ONBOARDING.md) in installed contexts.
4. Step 5 heading — labeled "Optional" but required for non-Cursor sync; consider renaming to clarify platform-specific requirement.
5. .gitignore workshop doc — unrelated to Jira work; fine to keep if intentional, but could be a separate commit.

Nice work on the cross-platform Jira signal design — this is ready to merge from my side.