refactor: vn reader mode#121
Merged
Merged
Conversation
fraaerasmus
added a commit
to fraaerasmus/Hoshi-Reader-Android
that referenced
this pull request
Jul 2, 2026
…eatures Upstream v1.3.0 brings a full-library Statistics dashboard, a service-owned Sasayaki playback rewrite (HuangAntimony#118) with its own foreground service, media notification, lock-screen controls, playback speed, media-button handling and M4B metadata, a VN reader pagination refactor (HuangAntimony#121), and assorted reader fixes. Sasayaki: both the fork and upstream independently built background playback. Adopt upstream's SasayakiPlaybackServiceRuntime/Notification/ReaderAttachment architecture and drop the fork's now-redundant stack (SasayakiPlaybackHolder, SasayakiMediaSession*, the restore/cue/playback coordinators, SasayakiReaderBinding, SasayakiMatchView). Re-thread the reader onto upstream's SasayakiPlayer + auto-page. Kept fork features, re-threaded onto upstream: 18-language kaihouguide lookup (submodule + .gitmodules stay ours), JSON settings backup (incl. SasayakiSettings export/import), multi-word phrase lookup + shift-hover (unioned with upstream's code-point-aware scan), footer page-info (getPageInfo/ReaderPageInfo), Sasayaki control position/scale (layered over upstream's dynamic sizing), edge-swipe brightness/volume, reader keyboard shortcuts, Custom-theme color presets, and the Hoshi Custom label / debug signing / update channel. Deferred to a follow-up (removed here to land upstream cleanly, recoverable from the pre-merge HEAD): the cross-tab now-playing mini-player and the Sasayaki sleep timer (to be re-threaded onto the new runtime), plus the reader-open perf JS tweaks (font-ready timeout / reveal-before-decode) that conflicted with upstream's reader tests. Dropped for good in favor of upstream's equivalents: hold-to-seek, headphone skip-action, 3.0x speed cap and lock-screen speed button. All 185 shared/reader JS tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.