feat: escrow security hardening, storage bounds, and admin safety improvements#248
Merged
Agbeleshe merged 2 commits intoApr 30, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces critical improvements across escrow handling, storage management, and admin configuration in the CraftNexus protocol. The focus is on strengthening security guarantees, ensuring safe lifecycle transitions, and improving long-term scalability.
Key Changes
1. Token Whitelist Enforcement on Legacy Escrows (#238)
Problem
Whitelist enforcement depended on global state, creating ambiguity for previously created escrows when rules change.
Solution
Key Behavior
Outcome
2. Recurring Escrow Cancellation Safety (#242)
Problem
Cancelling recurring escrows during active cycles could lead to:
Solution
Key Behavior
Outcome
3. ArtisanStakeQueue Storage Boundedness (#237)
Problem
Unbounded queue growth leads to:
Solution
Key Behavior
Outcome
4. PlatformConfig Admin Hardening (#240)
Problem
Admin configuration could become corrupted or invalid, leading to:
Solution
Key Behavior
Outcome
Key Areas Modified
Acceptance Criteria Summary
Related Issues
Closes #238
Closes #242
Closes #237
Closes #240