feat(reviews): add review sorting and filtering controls with dynamic empty states (#233) - #320
Open
OluwapelumiElisha wants to merge 1 commit into
Conversation
|
@OluwapelumiElisha Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #233.
This PR adds comprehensive sorting and filtering controls for community reviews across both the Global Reviews Page (
/reviews) and Project Detail Page (/projects/[id]). It also enhancesReviewListwith dynamic empty state banners that reflect active filter criteria.Changes Made
1. Components
ReviewList(dongle/components/reviews/ReviewList.tsx):emptyMessage?: stringandemptyTitle?: stringprops toReviewListProps.2. Global Reviews Page (
/reviews)app/reviews/page.tsx:recent), Oldest First (oldest), Highest Rating (highest), Lowest Rating (lowest), and Most Helpful (helpfulness).No reviews found matching project "Project Alpha" and 5-star rating. Try adjusting your filters.).3. Project Detail Page (
/projects/[id])app/projects/[id]/page.tsx:ReviewList.4. Tests
dongle/__tests__/components/ReviewSortingFiltering.test.tsx:ReviewListcustom empty state rendering.Acceptance Criteria Checklist
Verification & Testing
npx tsc --noEmitpassed with0errors.npm run buildcompleted successfully, generating static and dynamic routes.