feat: block project owners from self-reviewing via service guard and … - #325
Open
Challmejosh wants to merge 1 commit into
Open
feat: block project owners from self-reviewing via service guard and …#325Challmejosh wants to merge 1 commit into
Challmejosh wants to merge 1 commit into
Conversation
|
@Challmejosh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Challmejosh
force-pushed
the
review-owner-project
branch
from
August 4, 2026 08:45
7122b0c to
2d262ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #235
Summary
Project owners could previously submit ratings for their own projects, potentially biasing scores. This PR enforces the restriction at both the UI and service layers, and adds a dedicated hook to centralise the ownership check.
Changes
services/review/review.service.tsownerAddressparameter toaddReviewReviewValidationErrorso callers need no changes to their error-handlinghooks/useIsProjectOwner.ts(new)publicKeyagainst a project'sownerAddressfalsesafely when either value is absent (disconnected wallet, unclaimed project)app/projects/[id]/page.tsxisOwnerexpression withuseIsProjectOwnerproject.ownerAddressthrough toreviewService.addReviewso the service-layer guard fires even if the UI is bypassedTests
review.service.test.ts— self-review guarduseIsProjectOwner.test.ts39 / 39 tests pass.
Acceptance criteria
self-review guarddescribe block