Added COS Blog API and removed old Nurturing API#58
Open
drcraig wants to merge 28 commits intoHubSpot:masterfrom
CurataEng:master
Open
Added COS Blog API and removed old Nurturing API#58drcraig wants to merge 28 commits intoHubSpot:masterfrom CurataEng:master
drcraig wants to merge 28 commits intoHubSpot:masterfrom
CurataEng:master
Conversation
Contributor
There was a problem hiding this comment.
Did you mean to check this in?
Author
There was a problem hiding this comment.
I did, it seemed to affect how pip installed my fork. I'm not terribly
knowledgeable about Python packaging, but I assume that these should be
reverted (or really, the download_url should be updated to the new tag)
when you merge back into the true repo.
On Fri, Jan 24, 2014 at 10:55 AM, jessbrandi notifications@github.comwrote:
In setup.py:
description="A python wrapper around HubSpot's APIs", long_description=open('README.md').read(), author='HubSpot Dev Team', author_email='devteam+hapi@hubspot.com',
- url='https://github.com/HubSpot/hapipy',
- download_url='https://github.com/HubSpot/hapipy/tarball/v2.10.3',
- url='https://github.com/CurataEng/hapipy',
Did you mean to check this in?
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/58/files#r9152481
.
added 8 commits
July 30, 2015 13:09
Conflicts: setup.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to follow the conventions in the CMS Blog API.
The Nurturing API failed its tests because the endpoints appeared to no longer exist.