Refine Polish dictionaries and UI translations#115
Conversation
…pplement.txt). Improved translation of language_config.json for polish language. Added SOURCES.md for polish language words
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughTwo Polish language files updated: a new SOURCES.md documentation file detailing data provenance for word lists (SJP.pl and FrequencyWords sources, Apache 2.0 and MIT licenses), and Polish language configuration strings revised with updated translations, UI labels, and UI text. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Hugo0
left a comment
There was a problem hiding this comment.
Great contribution! The word list quality is a massive improvement — the current list has English words (pride, print, lewis), inflected forms, and archaisms. Your frequency-based approach with manual review is exactly what's needed.
Ran pytest locally — one issue to fix:
pl_5words.txt contains event, which has the letter v. Polish character set (pl_characters.txt) doesn't include v, so this fails the character validation test:
FAILED test_words_use_valid_characters[pl] - pl: Found 1 words with invalid characters. Examples: [('event', ['v'])]
Please remove event from pl_5words.txt (it's an English loanword anyway, not a great daily puzzle word).
Minor note: pl_5words_supplement.txt has ~100 words containing v (loanwords like covid, cover, drive, etc.). These won't cause test failures since the supplement validation is less strict, but users can't type v on the Polish keyboard layout — so those entries are effectively dead. Not blocking, but worth knowing.
Everything else looks good:
- UI translations are clearly native-quality (fixed machine-translated strings like "Dzielić" → "Udostępnij")
- 1,713 curated daily words is plenty (~4.7 years)
- 34K supplement words should drastically reduce the invalid word rate (currently 65% for Polish)
- SOURCES.md with licensing is a nice touch
Will merge once event is removed. Thanks for putting in the manual review work!
Hugo0
left a comment
There was a problem hiding this comment.
Great contribution! The word list quality is a massive improvement — the current list has English words (pride, print, lewis), inflected forms, and archaisms. Your frequency-based approach with manual review is exactly what's needed.
Ran pytest locally — one issue to fix:
pl_5words.txt contains "event", which has the letter "v". Polish character set (pl_characters.txt) doesn't include "v", so this fails the character validation test:
FAILED test_words_use_valid_characters[pl] - Found 1 words with invalid characters: [('event', ['v'])]
Please remove "event" from pl_5words.txt (it's an English loanword anyway, not a great daily puzzle word).
Minor note: pl_5words_supplement.txt has ~100 words containing "v" (loanwords like covid, cover, drive, etc.). These won't cause test failures since the supplement validation is less strict, but users can't type "v" on the Polish keyboard layout — so those entries are effectively dead. Not blocking, but worth knowing.
Everything else looks good:
- UI translations are clearly native-quality (fixed machine-translated strings like "Dzielić" to "Udostępnij")
- 1,713 curated daily words is plenty (~4.7 years)
- 34K supplement words should drastically reduce the invalid word rate (currently 65% for Polish)
- SOURCES.md with licensing is a nice touch
Will merge once "event" is removed. Thanks for putting in the manual review work!
|
fixed, merging. thx! |
* chore: refined full list of polish words (pl_5words.txt, pl_5words_supplement.txt). Improved translation of language_config.json for polish language. Added SOURCES.md for polish language words * fix: Remove 'event' from Polish word list (contains 'v', not in charset) --------- Co-authored-by: Hugo Montenegro <h@hugo0.com>
* chore: refined full list of polish words (pl_5words.txt, pl_5words_supplement.txt). Improved translation of language_config.json for polish language. Added SOURCES.md for polish language words * fix: Remove 'event' from Polish word list (contains 'v', not in charset) --------- Co-authored-by: Hugo Montenegro <h@hugo0.com>
Summary
This PR significantly refines and improves the Polish language support. The previous dictionary and solution lists contained low-quality data. This update replaces them with cleaner, frequency-based datasets and corrects the UI translations.
This PR aims to improve dictionaries for daily puzzle and guessing words. Before changes dictionary for polish words contains a lot of words from other languages (English, Spanish, even Finnish) and a lot of archaisms.
I've used open source word lists and some algorithms to generate two dictionaries:
pl_5words.txt: common polish words, base forms onlypl_5words_supplement.txt: all valid Polish words from SJP dictionary, multiple forms1. Dictionary Refinement - Daily Puzzles
File:
webapp\data\languages\pl\pl_5words.txtCount: 1,713 words
The solution list has been rebuilt from scratch using a cross-reference between SJP base forms and Polish movie subtitle frequency (https://github.com/hermitdave/FrequencyWords) data to ensure solutions are commonly known words.
Algorithm:
100)2. Dictionary Refinement - Valid Guesses
File:
webapp\data\languages\pl\pl_5words_supplement.txtCount: 34,150 words
Replaced the existing list with a cleaner extraction from the SJP dictionary https://sjp.pl/sl/odmiany/.
Filtering logic:
3. UI Translations
File:
webapp\data\languages\pl\language_config.jsonRefined the configuration file translations. The interface text has been rewritten to sound natural and native, fixing previous literal translations.
4. Sources
File:
webapp\data\languages\pl\SOURCES.mdAdded sources I used for rewriting all dictionaries, with their licenses (all open source as well).