-
Notifications
You must be signed in to change notification settings - Fork 43
feat: Auto-detect browser language on homepage #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
27ceb9a
feat: Auto-detect browser language on homepage with play CTA
Hugo0 ff61335
fix: TypeScript strict mode - handle undefined from split()
Hugo0 8aeb28f
refactor: Replace hero CTA with grid-first detected language
Hugo0 ccf1f7d
feat: Try all browser languages (navigator.languages) for detection
Hugo0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider
navigator.languagesfor better language matching coverage.The current implementation only checks
navigator.language(the primary language). For users whose primary locale isn't in the game (e.g.,zh) but whose second preference is (e.g.,fr), no CTA will appear.♻️ Proposed enhancement using `navigator.languages`
Minor:
iwlegacy Hebrew code not mapped.Some browsers (particularly older Windows locale settings) still report
iw(the deprecated ISO 639-1 code) instead ofhefor Hebrew. If Hebrew is in the game's language list, those users will silently get no CTA. The fix is included in the proposed diff above.Based on learnings: "Consider RTL (right-to-left) language support for Hebrew, Arabic, and Persian in UI code."
📝 Committable suggestion
🤖 Prompt for AI Agents