fix(evlog): respect status/statusCode on Error instances#218
Merged
HugoRCD merged 3 commits intoHugoRCD:mainfrom Mar 21, 2026
Merged
fix(evlog): respect status/statusCode on Error instances#218HugoRCD merged 3 commits intoHugoRCD:mainfrom
status/statusCode on Error instances#218HugoRCD merged 3 commits intoHugoRCD:mainfrom
Conversation
|
@benhid is attempting to deploy a commit to the HRCD Projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Thank you for following the naming conventions! 🙏 |
status/statusCode on Error instances
commit: |
This was referenced Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #217
📚 Description
parseError()has three branches for determining the HTTP status of an error:EvlogError,FetchError)Branch 2 is ignoring any
.statusor.statusCodeproperty sitting on the error object. This is a problem for frameworks that attach HTTP status to their native error classes, such as NestJS: when addingValidationPipewith a class-validator DTO, NestJS throwsBadRequestException(HTTP 400).BadRequestExceptionextendsHttpExceptionextendsError: it has no data property, so it falls through to Branch 2 and gets hardcoded as 500.Fix
The library already has
extractErrorStatus()inshared/errors.ts(used by the middleware layer) which does exactly what was needed. The fix is a one-line change in Branch 2 to callextractErrorStatus(error)instead of hardcoding 500.Tests
Added 5 new test cases under
describe('Error instances with status properties'):.statuson Error → respected (NestJS HttpException pattern).statusCodeon Error → respected (H3/Nitro pattern).statuspreferred over.statusCodewhen both exist📝 Checklist