Repository navigation
ci(review): replace the Merge Oncall with CODEOWNERS review routing - #657
Merged
Merged
Conversation
Every pull request was assigned to one Merge Oncall, who also owned the default CODEOWNERS rule, so one maintainer merged most pull requests. - Remove merge-oncall.json, the assignment workflow, and its validation. - Give each CODEOWNERS area a primary and a backup owner; one approval from either satisfies the area. - Authors with write access merge their own pull request after one approval; an approving code owner merges external contributions. - Add a reminder, posted every three days, that lists ready pull requests idle for three days and mentions whoever the next step waits on. Refs #656 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks done
|
Merge Oncall: @BobbyZhouZijian The merge oncall will route reviews and keep this pull request moving toward a clear decision. |
BobbyZhouZijian
marked this pull request as ready for review
September 27, 2026 08:49
BobbyZhouZijian
enabled auto-merge (squash)
September 27, 2026 08:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Implements accepted RFC #656. Every pull request was assigned to a single Merge Oncall, who also owned the default
CODEOWNERSrule. Over the last 30 days that one account merged 156 of about 200 pull requests. This change routes review and merge responsibility byCODEOWNERSinstead.Changes
.github/merge-oncall.json, theassign merge oncallworkflow, and the on-call validation incheck_community_files.py.CODEOWNERS: every area lists a primary and a backup owner, and one approval from either is enough. The default*rule is owned by @BobbyZhouZijian and @quao627, and general/docs/by @BobbyZhouZijian and @Benjamin-eecs.MAINTAINER.md: replace the Merge Oncall role with Code owner and add a Review routing section.review-reminders.yml. It runs daily, but only posts on every third UTC day, and can be triggered manually at any time. When it posts, it comments on a fixed[Task] Pull request review remindersissue with ready pull requests that have had no activity for three days, and mentions who each one is waiting on:CONTRIBUTING.md.Compatibility and operational impact
required_approving_review_countto 1 inprotect-mainto enforce the one-approval rule.Verification
pre-commit run --files <changed files>passed.python .github/scripts/check_community_files.pyreportedCommunity configuration is valid.AI assistance
Claude Code drafted the workflow,
CODEOWNERSbackup assignments (based on recent contribution history), documentation changes, and the RFC. I reviewed the changes and the resulting behavior.Checklist
AGENTS.md.README.i18n.yaml, or do not affect README content.Review and merge
Reviewers are requested automatically from
CODEOWNERS. See themaintenance model
for review and merge requirements.
🤖 Generated with Claude Code