refactor(workflow): delegate spec updates to subagents

[Hurblat]

Summary

• Delegate question resolution from sign-off commands to their respective subagents (requirements-definer, specification-writer)
• Add "Question Resolution Mode" to both agents for handling resolved questions
• Improve approval flow with structured AskUserQuestion options (Approve/Request changes)
• Bump version to 1.3.0

Test plan

• Run /feature prompt-test workflow through requirements sign-off
• Verify structured questions are resolved and moved to Resolved Questions section
• Verify approval flow presents Approve/Request changes options
• Run through specification sign-off and verify same behavior

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Added support for resolving questions within requirements and specification workflows.
  • Enhanced approval process with explicit decision options (Approve/Request Changes) for better workflow control.

• Chores

  • Bumped version to 1.3.0.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR version-bumps the claude-constructor plugin to 1.3.0 and introduces a new question-resolution workflow. When prompts contain "Resolved questions:", the requirements-definer and specification-writer agents enter a dedicated mode that parses resolved items, updates specifications by moving resolved questions to new sections, and removes corresponding open items. Sign-off commands are updated to use subagent delegation and formalizeuser approval via explicit tool-driven branching.

Changes

Cohort / File(s)	Summary
Version Bumps .claude-plugin/marketplace.json, package.json, plugins/claude-constructor/.claude-plugin/plugin.json	Incremented plugin version from 1.2.0 to 1.3.0 across marketplace, root package manifest, and plugin manifest.
Question Resolution in Agents plugins/claude-constructor/agents/requirements-definer.md, plugins/claude-constructor/agents/specification-writer.md	Added new "Handle Question Resolution Mode" step that detects "Resolved questions:" in prompts, parses resolved items, updates specification files by creating/appending "Resolved Questions"/"Resolved Technical Questions" sections, removes corresponding open questions, and exits without proceeding to other steps.
Updated Sign-Off Commands plugins/claude-constructor/commands/requirements-sign-off.md, plugins/claude-constructor/commands/specification-sign-off.md	Replaced inline post-processing with subagent delegation for question handling; replaced generic feedback flow with explicit "Get User Approval" tool using AskUserQuestion with binary options (Approve/Request changes), introducing branching logic to either proceed or trigger revision and loop.

Sequence Diagram(s)

sequenceDiagram
    actor User
    participant SignOffCmd as Sign-Off Command
    participant StateFile as State Management
    participant Subagent as Requirements/Spec Subagent
    participant SpecFile as Specification File
    
    User->>SignOffCmd: Submit resolved questions in prompt
    SignOffCmd->>StateFile: Read state management file
    StateFile-->>SignOffCmd: Current state
    SignOffCmd->>Subagent: Delegate question resolution
    Subagent->>SpecFile: Locate & read specification
    SpecFile-->>Subagent: Specification content
    Subagent->>SpecFile: Remove open question items
    Subagent->>SpecFile: Create/append "Resolved Questions" section
    SpecFile-->>Subagent: Updated
    Subagent-->>SignOffCmd: Resolution complete
    SignOffCmd->>SignOffCmd: Present specification for approval
    SignOffCmd->>User: Request approval (Approve/Request changes)
    alt Approve
        User-->>SignOffCmd: Approve
        SignOffCmd->>User: Proceed to finalization
    else Request changes
        User-->>SignOffCmd: Request changes
        SignOffCmd->>Subagent: Revise specification
        Subagent-->>SignOffCmd: Revised
        SignOffCmd->>SignOffCmd: Loop to review
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• feat: centralize workflow files in claude_constructor directory #34: Introduces foundational question-resolution and sign-off workflows that this PR extends with refined subagent delegation and user approval branching patterns.

---

🐰 Questions resolved, specs aligned,
Workflows refined with subagents combined,
Version bumped up to one-point-three,
User approval flows now working spree! ✨

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e39c47438

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Capture feedback text before invoking revision subagent

The new approval flow jumps directly from a binary AskUserQuestion response to invoking the requirements-definer with User feedback to address, but there is no step to actually collect the feedback text. If AskUserQuestion only returns the selected option, the subagent will be called without actionable input, so it cannot make the requested revisions. Consider adding a follow-up prompt for the feedback body when “Request changes” is selected (or explicitly documenting that AskUserQuestion returns freeform feedback).

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Capture feedback text before invoking revision subagent

Here too, the flow routes a “Request changes” selection straight into a subagent call that expects User feedback to address, but there is no instruction to gather the actual feedback content. If AskUserQuestion only returns the selected option, the revision step will run without the user’s change request. Adding a follow-up prompt for feedback (or clarifying that AskUserQuestion returns freeform text) would prevent silent no-op revisions.

Useful? React with 👍 / 👎.