Skip to content

Conversation

@Hurblat
Copy link
Owner

@Hurblat Hurblat commented Jan 20, 2026

Summary

  • Make step 8 (Add Issue Comment) conditional on provider not being "prompt"
  • Add completion message to signal workflow can continue
  • Bump version to 1.3.1

Test plan

  • Run /feature with --provider=prompt and verify specification sign-off completes without getting stuck
  • Verify workflow continues to git checkout step after approval

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores

    • Updated to version 1.3.1
  • Bug Fixes

    • Specification sign-off workflow now includes conditional step execution and completion notification

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

Warning

Rate limit exceeded

@Hurblat has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 33 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 7900cab and 208e1d3.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (4)
  • .claude-plugin/marketplace.json
  • package.json
  • plugins/claude-constructor/.claude-plugin/plugin.json
  • plugins/claude-constructor/commands/specification-sign-off.md
📝 Walkthrough

Walkthrough

The pull request updates the Claude Constructor plugin version to 1.3.1 and modifies the specification sign-off workflow to conditionally add issue comments only when the provider is not "prompt", otherwise skipping that step.

Changes

Cohort / File(s) Summary
Plugin Manifest Version Update
plugins/claude-constructor/.claude-plugin/plugin.json
Version bumped from "1.3.0" to "1.3.1"
Workflow Logic Conditional
plugins/claude-constructor/commands/specification-sign-off.md
Add Issue Comment step now conditionally executes based on provider type; skipped when provider is "prompt". Includes explicit completion note upon workflow finish.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A version bump, so small and neat,
A skip condition, oh how sweet!
When prompt arrives, we hop right past,
This plugin update's built to last! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title directly describes the main fix: making specification sign-off conditional to prevent it from getting stuck when provider is 'prompt'.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Hurblat Hurblat force-pushed the fix/specification-signoff-flow branch from 7900cab to 69fd7dd Compare January 20, 2026 11:02
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@plugins/claude-constructor/commands/specification-sign-off.md`:
- Around line 107-110: The completion message for specification sign-off must be
emitted unconditionally; update the flow so that the final "Specification
sign-off is complete" note is not inside the conditional that skips step 8 when
provider == "prompt". Move the completion message out of the provider-check
block (step 8) into its own step after the conditional, or explicitly add an
unconditional emission step that runs regardless of provider, while keeping the
existing conditional only for executing the Skill tool `/create-comment
[issue-key] "[specification details and assumptions]" $1`.

- Make step 8 (Add Issue Comment) conditional on provider not being "prompt"
- Add completion message to signal workflow can continue
- Bump version to 1.3.1

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@Hurblat Hurblat force-pushed the fix/specification-signoff-flow branch from 69fd7dd to 208e1d3 Compare January 20, 2026 11:03
@Hurblat Hurblat merged commit a92f053 into main Jan 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants