Open
Conversation
Co-authored-by: Shubham Sharma <shubhamsharma1172@gmail.com>
ananyo2012
reviewed
Mar 17, 2020
|
|
||
| ## Users | ||
|
|
||
| We should create individual user accounts for auditing purposes to later check who made what changes just in case of any anomalies. |
Member
There was a problem hiding this comment.
I think admin accounts are adequate as of now ? We just need to create a login page or just link to the admin login page. New users we can add via django admin.
|
|
||
| We should create individual user accounts for auditing purposes to later check who made what changes just in case of any anomalies. | ||
|
|
||
| ## Notifications Scheduler |
Member
There was a problem hiding this comment.
Will this send post to all platforms ? This seems to be a new feature request. Ideally this will require a calendar and should have a different page.
| The Application will be integrated as per the APIs defined in this Service layer and individual channel implementations will have the details | ||
| about establishing connection and event related operations. | ||
|
|
||
| This would make it easier to Plug N Play newer channels |
Member
There was a problem hiding this comment.
+1 . Please update what all file needs to be added for this.
ananyo2012
reviewed
Mar 17, 2020
| 1. For updating the final details, on the Meetup Manager event page, the user will provide the date value of the Label to pick the talks for. | ||
| 1. This parser will then fetch the issues from GitHub with the `scheduled` label as well as the given `date` label - eligible proposals[1] | ||
| 1. Since all the GitHub issues will be following the template format, it'll be easier to parse the title, abstract and speaker details. | ||
| 1. It'll then store this information in the meetup manager `talk` table with a FK association to `id` in event table |
Member
There was a problem hiding this comment.
Please add the database diagram in models.md
Member
|
@GoelJatin Can you have a look at the review comments ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Shubham Sharma shubhamsharma1172@gmail.com
Added the details to the GitHub Parser and Notification channels idea