Repository navigation
fix(hbs-gestures): scope touch-action, cancel hold on app switch, guard numeric options - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to the independent review of #22.
touch-action: pan-xonly on buttons that have a real swipe action (notnone), so vertical page drags and pinch zoom stay possible elsewhere on the bar.swipe_distanceandhold_timefall back to their defaults.test_lovelaceas a module, so discovery no longer runs the base suite twice; down drags end further inside the viewport.Verification
CI fix included
The E2E run of #22 failed on main: the horizontal buttons stack rejects duplicate links ("You can't use #hbs-native twice"), so the fixture card rendered as a configuration error. Each button now has its own link, and the swipe tests also assert that the Bubble Card pop-up is visible, not only the hash. Run 43640661092: 38 tests passed against isolated HA 2026.10.1 with Bubble Card v3.4.2; the same 8 HBS tests also passed against a local isolated container.