Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the project to Node.js 24 and pnpm 11, updating the environment configuration and downgrading Node.js type definitions. Feedback was provided regarding the pnpm-workspace.yaml configuration, specifically that allowBuilds should be defined as an array rather than an object to comply with pnpm 11 requirements. Additionally, the reviewer suggested using pnpm.overrides for @types/node to ensure version consistency across all dependencies and avoid potential TypeScript conflicts.
| allowBuilds: | ||
| esbuild: true |
There was a problem hiding this comment.
In pnpm 11, the allowBuilds field in pnpm-workspace.yaml is the replacement for onlyBuiltDependencies and it expects an array of strings rather than an object. The current configuration (esbuild: true) is likely invalid. Additionally, the existing onlyBuiltDependencies section on lines 4-5 is redundant and should be removed to adhere to the new configuration schema.
allowBuilds:
- esbuild| ], | ||
| "author": "Team Hyphen <hello@hyphen.ai>", | ||
| "license": "MIT", | ||
| "packageManager": "pnpm@11.0.9", |
There was a problem hiding this comment.
Downgrading @types/node to version 24 is consistent with the Node.js 24 migration, but happy-dom still pulls in version 25 as a dependency (as seen in the lockfile). This version mismatch often leads to TypeScript "Duplicate identifier" errors. It is recommended to add a pnpm.overrides block to force a single version of Node types across the entire dependency tree.
"packageManager": "pnpm@11.0.9",
"pnpm": {
"overrides": {
"@types/node": "^24.12.3"
}
},
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 19 19
Branches 1 1
=========================================
Hits 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore: migrating to pnpm 11