Skip to content

chore: migrating to pnpm 11#42

Closed
jaredwray wants to merge 1 commit intomainfrom
chore-migrating-to-pnpm-11
Closed

chore: migrating to pnpm 11#42
jaredwray wants to merge 1 commit intomainfrom
chore-migrating-to-pnpm-11

Conversation

@jaredwray
Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines and Code of Conduct
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
chore: migrating to pnpm 11

@jaredwray jaredwray closed this May 9, 2026
@jaredwray jaredwray deleted the chore-migrating-to-pnpm-11 branch May 9, 2026 22:37
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project to Node.js 24 and pnpm 11, updating the environment configuration and downgrading Node.js type definitions. Feedback was provided regarding the pnpm-workspace.yaml configuration, specifically that allowBuilds should be defined as an array rather than an object to comply with pnpm 11 requirements. Additionally, the reviewer suggested using pnpm.overrides for @types/node to ensure version consistency across all dependencies and avoid potential TypeScript conflicts.

Comment thread pnpm-workspace.yaml
Comment on lines +2 to +3
allowBuilds:
esbuild: true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In pnpm 11, the allowBuilds field in pnpm-workspace.yaml is the replacement for onlyBuiltDependencies and it expects an array of strings rather than an object. The current configuration (esbuild: true) is likely invalid. Additionally, the existing onlyBuiltDependencies section on lines 4-5 is redundant and should be removed to adhere to the new configuration schema.

allowBuilds:
  - esbuild

Comment thread package.json
],
"author": "Team Hyphen <hello@hyphen.ai>",
"license": "MIT",
"packageManager": "pnpm@11.0.9",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Downgrading @types/node to version 24 is consistent with the Node.js 24 migration, but happy-dom still pulls in version 25 as a dependency (as seen in the lockfile). This version mismatch often leads to TypeScript "Duplicate identifier" errors. It is recommended to add a pnpm.overrides block to force a single version of Node types across the entire dependency tree.

  "packageManager": "pnpm@11.0.9",
  "pnpm": {
    "overrides": {
      "@types/node": "^24.12.3"
    }
  },

@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (87e6153) to head (fca7ec9).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #42   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           19        19           
  Branches         1         1           
=========================================
  Hits            19        19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant