Repository navigation
fix: remove warnings on optimized range heuristic - #111
Merged
Tejasshack merged 2 commits intoOct 15, 2026
Merged
Conversation
|
This removes the public FibonacciIntegerRangeEncoder.decode(BitString) signature. Downstream callers will stop compiling for a warning fix. Could the one-argument overload stay and delegate to decode(reader, true)? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not really a bug, but generally just tamping down useless logs. this pr #107 does a heuristic attempt to try to determine if we are in a fibonacci range or not. in that attempt i have been finding that there were a bunch of warnings being produced which are not actionable. try running TcfCaV1Test and see the warnings on the 4.X branch vs this branch.
solution was to suppress the size warnings when we are in this heuristic mode using a
strictflag