Repository navigation
UoA reader updates - #6
Merged
Merged
Conversation
Fix logic to handle a nan passed as calibration file
kujaku11
merged commit Sep 11, 2026
4580b78
into
IAGA-DVI-DataStandards:develop
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 05
Updates with:
Reader Registration: for Lemi-423, EDL PR6-24 and legacy orange box.
Filter Gain Direction: gains are stored counts to physical in
pr624.pyandlemi423.py. MTH5 divides by the total gain when removing a response, so they must be stored physical to recorded.Filters Marked Not Applied:
pr624.py:760writesapplied=False. Aurora only divides out stages flagged applied, so the sensor and interface responses stay in the data.AppliedFilter Field Name: the same call passes
sequence=sequence.AppliedFiltertakesstage, notsequence, so every stage was written asNone.LEMI-120 Sensitivity: updated to 400 mV/nT.
LEMI-423 Reader Cannot Run: four errors before it returns, with
MTimecalled positionally at three sites,data_type = "MTBB"where the enum takesBBMT,ch_metadata.filter.namefrom the pre-1.0 mt_metadata API, andChannelTSandRunTSused but never imported.Orange Box Format: records are 21 bytes, not 18; the first header field is a sample count, not a sample rate; and the rate comes from the filter point as
10e6 / (512 * filterpoint).AppleDouble Sidecars:
Collection.get_filesmatches._namesidecars, which share the data extension but hold resource fork bytes.miniSEED PR6-24: added miniseed support for EDL PR6-24, as AusLAMP Victoria was recorded in this format.
B423 Collection Summaries: building a Lemi-423 collection read every file in full. read_summary now memmaps the time columns and takes min/max, the same start/end the old sorted parse reported, so summaries come from the 1024-byte header plus two columns.
LEMI-424 Speed and the 16-Column Variant: read_metadata tail-seeks instead of parsing the whole file, position columns map unique values only, and multi-file reads join once; the n_samples estimate divides by the first line's width instead of a hard-coded 152. Instruments with gps/clock problems write a 16-column file, time + fields + battery, no GPS block; which the reader could not open at all. The reader now sniffs the first line's field count; position properties return None when there is no GPS block.
Repeated Parsing in Phoenix and miniSEED: recmeta.json was re-parsed for every channel reader; now cached per (path, mtime). EDL miniSEED reads pass format="MSEED" so obspy skips its format-detection cascade.