Skip to content

Phoenix reader update - #8

Merged
kujaku11 merged 3 commits into
IAGA-DVI-DataStandards:developfrom
bvkay:phoenix-update
Sep 11, 2026
Merged

kujaku11 merged 3 commits into
IAGA-DVI-DataStandards:developfrom
bvkay:phoenix-update

Conversation

@bvkay

@bvkay bvkay commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Fixes #7

  1. Prefer EMpower's receiver metadata when present: empower_recmeta.json holds corrections made after the survey, so it is taken over recmeta.json when both exist.

  2. Join sequence reads once: read_sequence grew the array with np.append per file, copying everything already read each time. Chunks now concatenate once at the end.

  3. Fix the 24-bit decode (the Phoenix NativeReader.read() decodes 24-bit samples with a byte from the next sample #7 fix): read() strided 4-byte windows over the 3-byte samples, so the low byte of every decoded value was the next sample's high byte (error bounded at 255 counts, ~5.9e-7 V at the 5 V range) and the last window read one byte past the buffer. Each sample is now padded to 4 bytes with a zero low byte, the same convention as read_frames. Affects the .bin native path only; the float td_* formats are untouched. This changes output values for .bin reads.

@bvkay
bvkay requested a review from kujaku11 August 27, 2026 05:32
@kujaku11
kujaku11 changed the base branch from main to develop September 11, 2026 21:50

@kujaku11 kujaku11 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvkay Thanks for the continuous updates. This is great.

@kujaku11
kujaku11 merged commit c1b03cd into IAGA-DVI-DataStandards:develop Sep 11, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phoenix NativeReader.read() decodes 24-bit samples with a byte from the next sample

2 participants