Repository navigation
Phoenix reader update - #8
Merged
Merged
Conversation
kujaku11
merged commit Sep 11, 2026
c1b03cd
into
IAGA-DVI-DataStandards:develop
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
Prefer EMpower's receiver metadata when present:
empower_recmeta.jsonholds corrections made after the survey, so it is taken overrecmeta.jsonwhen both exist.Join sequence reads once:
read_sequencegrew the array with np.append per file, copying everything already read each time. Chunks now concatenate once at the end.Fix the 24-bit decode (the Phoenix NativeReader.read() decodes 24-bit samples with a byte from the next sample #7 fix):
read()strided 4-byte windows over the 3-byte samples, so the low byte of every decoded value was the next sample's high byte (error bounded at 255 counts, ~5.9e-7 V at the 5 V range) and the last window read one byte past the buffer. Each sample is now padded to 4 bytes with a zero low byte, the same convention asread_frames. Affects the.binnative path only; the floattd_*formats are untouched. This changes output values for.binreads.