Repository navigation
Conversation
reluctantly, there is different key word names for organization and url.
tipper units should be "[]" and impedance units should be "[mV/km]/[nT]".
The official representation of WGS84 is with a space, but here we are forcing no space.
Switch `DataType.units` default to the canonical `[mV/km]/[nT]` form and update related tests to match validator behavior for empty/invalid units (`[]`) and XML output. Adjust instrument XML tests to expect `settings` to always be emitted per EMTFXML requirements, including null-like values. Update EMTFXML provenance test fixtures to include creator/submitter organization and URL fields from current metadata output.
Update EMTFXML provenance tests to import `Person` from the EMTFXML metadata module and use the current `Person.org` field instead of `organization`. This keeps the test suite aligned with the actual EMTFXML metadata model and serialized field names.
Change `ProcessingSoftware.last_mod` default to use `MTime(...).date`, making it a normalized ISO date string instead of an `MTime` object. Update EMTFXML software metadata tests to assert date-only string behavior for `last_mod` while keeping `last_updated` assertions as `MTime`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some updates need to be done to EMTFXML and how it is written.
provenance.submitterandprovenance.createorthe key words should be changes fromorganizationtoorgandurltoorg_url. This is a pain and should be dealt with in the future to have consistent key words.DataTypeto have brackets like inmV/km/nTgoes to[mV/km]/[nT]and an unknown unit goes to "[]"Location.datumif "WGS 84" remove the space, even though that is the official representation.settingssubelement to anInstrumentobjectProcessDateandSoftware.last_modto return just dates