Skip to content

RR trivial updates may 2024#497

Closed
robredpath wants to merge 2 commits into
version-2.03from
rr-trivial-updates-may-2024
Closed

RR trivial updates may 2024#497
robredpath wants to merge 2 commits into
version-2.03from
rr-trivial-updates-may-2024

Conversation

@robredpath
Copy link
Copy Markdown
Contributor

Fixing some very trivial typos and consistency issues I spotted while looking at the schemas.

@robredpath robredpath requested review from Bjwebb and stevieflow May 28, 2024 12:46
@robredpath
Copy link
Copy Markdown
Contributor Author

Fixes #477

@stevieflow
Copy link
Copy Markdown
Contributor

stevieflow commented May 28, 2024

Very interesting, thanks @robredpath !

All the punctuation changes would be welcome, and don't seem to change any meaning of the schema text

The two changes that (rightly) change the word activity for organisation are also good spots. They feel slightly different to the punctuation - a correction, rather than a grammatical improvement. But that's splitting hairs [full stop].

Over to @Bjwebb for thoughts....

<xsd:documentation xml:lang="en">
Default ISO 4217 currency code for all financial values in
this activity report. If this is not declared then the
this organisation report. If this is not declared then the
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree - the org file contains financial data, so this should say "organisation".

A date/time stamp for when this file was generated. This
is not necessarily the last-updated date for the
individual activity records in it. Use of this attribute
individual organisation records in it. Use of this attribute
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also agree. There can be multiple organisations in any organisation file, and this timestamp relates to them

@stevieflow
Copy link
Copy Markdown
Contributor

@robredpath best to close this PR, whilst we try out these things via #508 (review) ?

@robredpath robredpath closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants