Skip to content

fix: missing multi-select JS code in production build#78

Merged
chrisarridge merged 2 commits into
mainfrom
chris-fix-multiselect-build
Nov 24, 2025
Merged

fix: missing multi-select JS code in production build#78
chrisarridge merged 2 commits into
mainfrom
chris-fix-multiselect-build

Conversation

@chrisarridge
Copy link
Copy Markdown
Contributor

This is a really small quick fix to get the multi-select custom HTML element into the production build. It partially addresses #77 but does not make any changes to the storybook to add working example code.

@chrisarridge chrisarridge requested review from a team and codemacabre November 19, 2025 13:18
Comment thread src/js/main.js
@codemacabre
Copy link
Copy Markdown
Collaborator

codemacabre commented Nov 20, 2025

Whoops, that was an oversight. Thanks for spotting this, @chrisarridge. I've requested a small change just for consistency, but otherwise approved.

@codemacabre
Copy link
Copy Markdown
Collaborator

codemacabre commented Nov 20, 2025

@chrisarridge Rather than create a separate branch and PR, I thought I'd add on to this PR; hope that's okay.

I've updated the <multi-select> to also allow for <options> elements to be added as children, as well as the original implementation to add options programmatically, which on reflection wasn't the best way of using it (and as you noted, wasn't well documented). This should be much more intuitive and better documented now.

@codemacabre codemacabre force-pushed the chris-fix-multiselect-build branch from 1610bf7 to 7f4c2e3 Compare November 20, 2025 08:09
@codemacabre codemacabre requested a review from a team November 20, 2025 08:09
@chrisarridge chrisarridge merged commit d998e4a into main Nov 24, 2025
3 checks passed
@chrisarridge chrisarridge deleted the chris-fix-multiselect-build branch November 24, 2025 07:39
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 4.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants