Skip to content

Data card variations#83

Merged
codemacabre merged 3 commits into
mainfrom
ml/data-card-variations
Feb 24, 2026
Merged

Data card variations#83
codemacabre merged 3 commits into
mainfrom
ml/data-card-variations

Conversation

@codemacabre
Copy link
Copy Markdown
Collaborator

This update subtly amends the existing design of data cards to match the Figma and edits their structure to allow for headers and title background colours.

Primarily, this is to add a new 'summary' variant to match the Figma:

image

@codemacabre codemacabre requested review from a team and robredpath February 9, 2026 13:55
@codemacabre codemacabre self-assigned this Feb 9, 2026
@codemacabre codemacabre force-pushed the ml/data-card-variations branch from 5368f25 to 6225013 Compare February 9, 2026 13:56
@robredpath
Copy link
Copy Markdown
Contributor

Thanks @codemacabre . This is slightly different from the Figma - e.g. the organisation_name isn't an underlined link, and the labels are using a smaller (maybe just narrower?) font

Screenshot 2026-02-09 at 17 35 40 vs
Screenshot 2026-02-09 at 17 35 58

(figma screenshot for reference)
Screenshot 2026-02-09 at 17 33 28

I suspect that's because of the difference between creating designs in Figma and actually implementing them in code with the real, live design system.

I don't think we need to copy the Figma pixel-for-pixel and any ambiguity should be resolved in favour of usability as long as it's broadly faithful to the original design. If we need to introduce another font that's not the end of the world; we deliberately punted the question of "small text" (labels, tags, etc) to a future time when we were scrambling to choose the current fonts, so this may be that future time.

@robredpath
Copy link
Copy Markdown
Contributor

Actually, one other point: for the design system can we make the summary card more generic (sample labels, etc) and then make the dashboard one instance of the summary data card? I'm anticipating that fairly quickly we're going to be wanting to modify the dashboard summary so anything we can do to make our future lives easier in terms of flexibility is welcome.

@codemacabre
Copy link
Copy Markdown
Collaborator Author

the organisation_name isn't an underlined link

I don't think we should introduce a new link style just for this.

the labels are using a smaller (maybe just narrower?) font

This is a result of having to 'eyeball it' - the Figma is not inspectable so I've based the actual design on finding variables which approximate the style. I can make some tweaks if necessary.

However,

I don't think we need to copy the Figma pixel-for-pixel

...so perhaps it's fine as-is?

for the design system can we make the summary card more generic (sample labels, etc) and then make the dashboard one instance of the summary data card?

I can certainly make the story more generic; it doesn't really matter what the text inside a story is, whether "reporting org on registry" or "generic title (small)", or whatever. The resulting design is the important thing here. There isn't really a concept of instances within the design system, just an example design for each component, etc.

@codemacabre
Copy link
Copy Markdown
Collaborator Author

With generic information:

image

@codemacabre codemacabre merged commit c631382 into main Feb 24, 2026
3 checks passed
@codemacabre codemacabre deleted the ml/data-card-variations branch February 24, 2026 09:43
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

🎉 This PR is included in version 4.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants