Incorrect syntax/usage of nz_azConnector command run should return error.#14
Open
Ram-Nerpagar wants to merge 1 commit into
Open
Incorrect syntax/usage of nz_azConnector command run should return error.#14Ram-Nerpagar wants to merge 1 commit into
Ram-Nerpagar wants to merge 1 commit into
Conversation
ssayyed21
approved these changes
Mar 28, 2023
Collaborator
ssayyed21
left a comment
There was a problem hiding this comment.
approving as per Dev.
deleisha
reviewed
Mar 28, 2023
Signed-off-by: Ram-Nerpagar <Ram.Nerpagar@ibm.com>
devchandra-l
approved these changes
Mar 30, 2023
Member
|
As far as I can remember, our idea was that with single command the customer would be able to move all backups for all databases. Usually nzbackup -dir option is some mount path of SAN/LAN storage where all backups are taken. So with single "nz_azConnector -dir " command, we can move all /Netezza/// hierarchy in one go. Please check if that is correct. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Problem:- nz_azConnector command was not returning error even when - was not passed to flag in command.
Solution:- 1) If an user don't pass a value for a particular flag then it will error out an message. But for database,
directory and npshost flags the code will fetch the values from the environment variables even if the
user don't pass the value while running the command.
2) Code will print a proper message if user don't pass '-' to a particular flag. If user don't pass '-' to a flag
then Go language treats every argument after that particular flag as an positional argument.
Testing:- 1) If user don't pass a value for db while running the command then the code will fetch the value as
"NZ_DATABASE" from the environment variables. Same for dir and npshost. Hence the code will run fine
even if the value for db, dir and npshost is not provided in the command.
2) In the command if user missed to pass '-' to storage-account then the code will consider remaining
command as a value for npshost. Hence the code will print a proper message showing that "Did you
miss '-' in any flag? If so Go treats remaining flags as the positional arguments".