Skip to content

Conversation

@worksofliam
Copy link
Member

-wp makes it generate a makefile that includes parents, but also includes the parents' children and their children - this is way too much for simple builds.

We need a new parameter, -wpc, which determines if parents children should be included in the build.

Below is a message from me to a customer about this issue:


I was able to recreate it easily:

image

But, -wp (with-parents) does solve the problem partially – which makes sense, because the markdown repo includes the impacted parents by default.

The issue is that -wp is including the children of each parent. Here is the makefile with -wp:

all: .logs .evfevent library $(PREPATH)/NEMP.FILE $(PREPATH)/NEWEMP.PGM $(PREPATH)/DEPTS.PGM

Notice that the objects in all match the markdown. But, now the dependency list comes in:

…
$(PREPATH)/DEPTS.PGM: $(PREPATH)/EMPLOYEES.PGM $(PREPATH)/NEWEMP.PGM $(PREPATH)/DEPARTMENT.FILE $(PREPATH)/DEPTS.FILE
…

It is actually including the children (the required objects) to build each object, which is way more than what the markdown provides.

I will have to see about adding an additional parameter on whether to include these or not.

Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam worksofliam marked this pull request as draft July 28, 2025 13:54
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam worksofliam marked this pull request as ready for review July 28, 2025 19:58
@worksofliam worksofliam merged commit 687a37d into main Jul 28, 2025
4 checks passed
@worksofliam worksofliam deleted the feature/with_parents_children branch July 28, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants