This repository was archived by the owner on Oct 9, 2025. It is now read-only.
MOB-1552: add support for dynamic affiliation and connection types.#49
Open
m-revetria wants to merge 11 commits into
Open
MOB-1552: add support for dynamic affiliation and connection types.#49m-revetria wants to merge 11 commits into
m-revetria wants to merge 11 commits into
Conversation
mirland
previously approved these changes
Jul 10, 2020
Comment on lines
+36
to
+37
| implementation "androidx.appcompat:appcompat:${rootProject.ext.androidXAppCompat}" | ||
| implementation project(':webverifylib') |
Contributor
There was a problem hiding this comment.
Suggested change
| implementation "androidx.appcompat:appcompat:${rootProject.ext.androidXAppCompat}" | |
| implementation project(':webverifylib') | |
| implementation project(':webverifylib') | |
| implementation "androidx.appcompat:appcompat:${rootProject.ext.androidXAppCompat}" |
| * The type of supported affiliations | ||
| */ | ||
| public enum IDmeAffiliationType { | ||
| public enum IDmeAffiliationType implements IDmeAffiliation { |
Contributor
There was a problem hiding this comment.
override annotation is missing
| * @see IDmeAffiliationType | ||
| */ | ||
| public interface IDmeAffiliation { | ||
| String getKey(); |
Contributor
There was a problem hiding this comment.
add NonNull annotation so we can use it in kotlin
| public void registerAffiliation(@NonNull Activity activity, | ||
| @NonNull IDmeScope scope, | ||
| IDmeAffiliationType affiliationType, | ||
| IDmeAffiliation affiliation, |
Contributor
There was a problem hiding this comment.
add nullability here, it's required for kotlin
mirland
changed the title
BryanVision
previously approved these changes
Feb 1, 2021
…ctivity was called before the redirection activity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements MOB-1552: ID.me WebVerify SDK: support for dynamic affiliations types without rebuilding the SDK
Description
Allow to pass any affiliation or connection type to the registration flow regardless of those statically defined in the SDK. This adds supports for dynamic affiliation and connection types in the ID.me mobile app.
Changes proposed in this request:
registerAffiliationmethod.registerConneectionmethod.IDmeAffiliationTypeenum is kept so partners have static access to supported affiliations.IDmeConnectionTypeenum is kept so partners have static access to supported connections.