WindIO Control Inputs#293
Conversation
|
@dzalkind - There are a lot of yaml-changes here beyond just controls inputs? Was that your intention? |
|
Not really. I can revert the non-controls changes for this PR to simplify. When I copied the inputs from windIO to here, there were a number of other differences, so I figured I'd raise that issue while I was here. |
Yeah, I would vote for a more targeted change in the control parameters in this PR if that is okay. The timing is this is good and I was able to approve #290 to stamp a new release with windio v2. @ptrbortolotti - if you see anything critically wrong in the ontology yaml files based on some of the other changes drafted here, please chime in. |
|
Sounds good. I've reverted it to the controls changes only. For future reference, this commit is a good summary of all the differences: 6f379ab |
|
We will wait until the release of WindIO v2.1 for this PR |
|
@dzalkind - WindIO v2.1 is now available and pypi. Can you please take another look at the tests here and let me know if you want help to debug them? |
|
I think we'll also need WISDEM to update to use v2.1 for these tests. |
Purpose
Update windIO inputs from the windIO repository: IEAWindSystems/windIO#175
Note: there are other changes (besides the control schema) from there to here, and I'm not sure which are most up-to-date.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
xin the boxes that apply.