Skip to content

WindIO Control Inputs#293

Merged
gbarter merged 3 commits into
IEAWindSystems:windio2p1from
dzalkind:windio_controls
Feb 25, 2026
Merged

WindIO Control Inputs#293
gbarter merged 3 commits into
IEAWindSystems:windio2p1from
dzalkind:windio_controls

Conversation

@dzalkind
Copy link
Copy Markdown
Contributor

Purpose

Update windIO inputs from the windIO repository: IEAWindSystems/windIO#175

Note: there are other changes (besides the control schema) from there to here, and I'm not sure which are most up-to-date.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@gbarter
Copy link
Copy Markdown
Collaborator

gbarter commented Feb 11, 2026

@dzalkind - There are a lot of yaml-changes here beyond just controls inputs? Was that your intention?

@dzalkind
Copy link
Copy Markdown
Contributor Author

Not really. I can revert the non-controls changes for this PR to simplify.

When I copied the inputs from windIO to here, there were a number of other differences, so I figured I'd raise that issue while I was here.

@gbarter
Copy link
Copy Markdown
Collaborator

gbarter commented Feb 11, 2026

Not really. I can revert the non-controls changes for this PR to simplify.

When I copied the inputs from windIO to here, there were a number of other differences, so I figured I'd raise that issue while I was here.

Yeah, I would vote for a more targeted change in the control parameters in this PR if that is okay. The timing is this is good and I was able to approve #290 to stamp a new release with windio v2. @ptrbortolotti - if you see anything critically wrong in the ontology yaml files based on some of the other changes drafted here, please chime in.

@dzalkind
Copy link
Copy Markdown
Contributor Author

Sounds good. I've reverted it to the controls changes only.

For future reference, this commit is a good summary of all the differences: 6f379ab

@gbarter
Copy link
Copy Markdown
Collaborator

gbarter commented Feb 12, 2026

We will wait until the release of WindIO v2.1 for this PR

@gbarter
Copy link
Copy Markdown
Collaborator

gbarter commented Feb 16, 2026

@dzalkind - WindIO v2.1 is now available and pypi. Can you please take another look at the tests here and let me know if you want help to debug them?

@dzalkind
Copy link
Copy Markdown
Contributor Author

I think we'll also need WISDEM to update to use v2.1 for these tests.

@gbarter gbarter changed the base branch from develop to windio2p1 February 25, 2026 22:26
@gbarter gbarter merged commit e221ed4 into IEAWindSystems:windio2p1 Feb 25, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants