merge-dev-to-main-8.95.0#1048
Merged
Merged
Conversation
* Convert pseudobulk sets page to Typescript. * Move the new functions to retrieve objects related to file sets to a new `lib/file-sets.ts` file. This will have to be merged with the same file in another branch. * Allow database-object helpers and file-set request utilities to accept arrays of paths as well as embedded objects, including embedded arrays without @type values. This updates pseudobulk set data loading to use the shared path extraction logic and adds donor links to the file-set type definition. * Add Jest coverage for file set association helpers, including associated file sets, donors, publications, and samples. The tests verify successful bulk fetches, deduped related objects, empty relationship handling, and non-database object inputs. * Update the Jest tests for lib/common-requests.ts. * Add tests for database object type guards, array validation, type-specific checks, and path extraction behavior. Update the donor object type so documents can be omitted when absent from donor responses. * Get full Jest coverage for lib/files.ts. * Fix build errors from the latest Typescript changes. Update Jest tests with these new changes. * Relax the search-results guard to accept any @type array and simplify file graph child-file handling now that native file paths are already validated. Also clean up assay comments and remove a stale commented assignment. * Correct a comment.
forresttanaka
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.