44965: Failed test: Player - Video: show#11107
Open
alex40724 wants to merge 3 commits intoILIAS-eLearning:release_10from
Open
44965: Failed test: Player - Video: show#11107alex40724 wants to merge 3 commits intoILIAS-eLearning:release_10from
alex40724 wants to merge 3 commits intoILIAS-eLearning:release_10from
Conversation
Member
Author
|
The label seem to be obligatory for some browsers (e.g. Firefox), so I would not make it an optional parameter even if it breaks backwards compatibility - hence the Jour Fixe label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://mantis.ilias.de/view.php?id=44965
The PR also includes the text changes requested here:
https://mantis.ilias.de/view.php?id=44964