Skip to content

remove rowan dependency - #877

Merged
whoenig merged 4 commits into
mainfrom
rm-rowan-dependency
Jul 27, 2026
Merged

remove rowan dependency#877
whoenig merged 4 commits into
mainfrom
rm-rowan-dependency

Conversation

@whoenig

@whoenig whoenig commented Jul 21, 2026

Copy link
Copy Markdown

No description provided.

@whoenig
whoenig marked this pull request as draft July 21, 2026 19:44
@knmcguire

Copy link
Copy Markdown
Collaborator

Seems good to me!

Also a quick check, transforms3d package is available as ubuntu package: https://packages.ubuntu.com/noble/python/python3-transforms3d

So that also makes it possible to add that dependency at build time already

@whoenig

whoenig commented Jul 26, 2026

Copy link
Copy Markdown
Author

So there are two more places of rowan that I didn't remove. They are both in the backend of the sim (one for the physics with numpy, one for rendering the AI-deck view using blender). Removing them there wouldn't make sense to me, because they use more advanced functions of rowan (like proper integration over SO(3)). Would you be still fine with merging as is? It likely improves the situation for most users.

@knmcguire

Copy link
Copy Markdown
Collaborator

That would be fine I think, then we just need to add those instructions to the installation probably

@whoenig
whoenig marked this pull request as ready for review July 27, 2026 18:52
@whoenig
whoenig merged commit a9c0cb5 into main Jul 27, 2026
6 checks passed
@whoenig

whoenig commented Jul 27, 2026

Copy link
Copy Markdown
Author

The instructions are still untouched in the docs (and include that one should install rowan). I merged this so that we see if it already improves the build.

@whoenig
whoenig deleted the rm-rowan-dependency branch July 27, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants