Skip to content

Merge the "plugin boilerplate" branch containing WP VIP fixes and other things - #64

Open
benlk wants to merge 49 commits into
masterfrom
plugin-boilerplate
Open

Merge the "plugin boilerplate" branch containing WP VIP fixes and other things#64
benlk wants to merge 49 commits into
masterfrom
plugin-boilerplate

Conversation

@benlk

@benlk benlk commented May 30, 2018

Copy link
Copy Markdown
Collaborator

I'm creating this PR to track stuff that started happening in the plugin-boilerplate branch that was never merged with master. It's a bunch of things. Before this pull request is merged, we need to:

  • figure out what changes
  • figure out what issues this plugin addresses

Changes

Questions

Post-merge actions

  • bump version number
  • release

rclachance and others added 30 commits June 22, 2017 17:04
@rclachance
working on boilerplate in subfolder
6166c15
@rclachance
remove cmb2, rename options file/class
3b95655
@rclachance
wip on migrating options page
27e5e28
@rclachance
finished options page conversion
cb1a869
@rclachance
migrate widget into new structure
d7d1aac
@aschweigert
re-run VIP code standards, fix whitespace
82d133b
RC Lations
Merge pull request #47 from INN/fix-whitespace
94bf5cb 
re-run VIP code standards, fix whitespace
@aschweigert
remove spaces in size strings on save
c0af412
@aschweigert
fix broken callback
0e5d47a
@aschweigert
fix invalid foreach warning when breakpoints are not yet defined
f9cb6a7
@aschweigert
add some error conditions
a5f2c26
@aschweigert
add settings link, closes #36
5c2c119
@aschweigert
Merge pull request #50 from INN/36-add-settings-link
d14d517 
add settings link, closes #36
@aschweigert
Merge pull request #48 from INN/32-remove-spaces-on-save
912d8e8 
remove spaces in size strings on save
@aschweigert
merge plugin boilerplate
f099f05
@aschweigert
remove debugging code
ab2c6ef
@aschweigert
do error handling more good
98c6c87
@aschweigert
Merge pull request #49 from INN/fix-options-save
3317929 
options page fixes
@rclachance
Implementing solution from #24
0756967
@rclachance
little phpcs fixes
b3f2961
@rclachance
add empty boilerplate include to migrate dfw-init.php into
5e6b6cc
@rclachance
adding classes for breakpoint and ad slot
1003147
@aschweigert
load the other files
22964a6
@aschweigert
proper sanitization
d0449d4
@aschweigert
put the ad slot class here
8e3e77f
@aschweigert
put the ad-slot class here
905d978
@aschweigert
ok this seems to work
99f7ab7
@aschweigert
mostly working?
a714954
@aschweigert
fix most of the js stuff
e923a0a
@aschweigert
actually load the js
fc20eb4
aschweigert and others added 19 commits July 18, 2017 16:37
@aschweigert
no abbreviation
3f8ff8b
@aschweigert
use wp_json_encode here instead of esc_js
0edef92
@aschweigert
prefix options + update function, closes #52
1465789
@aschweigert
use filters for setting network_code and breakpoints from theme
48ebd3a
@aschweigert
adding additional breakpoints when defined by the theme is a bad idea
c1e268d
@aschweigert
remove debugging code
f453086
@rclachance
phpcs fixes
8b3981b
@aschweigert
make widgets work
e4de962
@aschweigert
Merge branch 'plugin-boilerplate' of github.com:INN/DoubleClick-for-W…
41355dc 
…ordPress into plugin-boilerplate
@aschweigert
address VIP code review issues
b39c12f
@rclachance
check for empty breakpoints array
e5a2431
@rclachance
bugfixes for network code check
7b57574
@rclachance
only disable inputs if filter is being used
3098503
@rclachance
updated message
eb45126
@aschweigert
add option to not load default css, closes #54
9e25f27
@aschweigert
add support for out of page ad units
ea8e331
@aschweigert
apply correct keywords to cat and tag archive pages, cleanup
d9cb07e
RC Lations
Merge pull request #57 from INN/adjust-targeting
43f133f 
apply correct keywords to cat and tag archive pages, cleanup
@aschweigert
Merge pull request #56 from INN/add-outofpage-support
4079568 
add support for out of page ad units
@benlk
benlk requested review from aschweigert and rclachance May 30, 2018 21:12
@benlk

benlk commented Oct 15, 2018

Copy link
Copy Markdown
Collaborator Author

This:

  • ❌ adds a lot of boilerplate files
  • ❓ deletes the docs?
  • 😬 refactors the plugin
  • 😕 adds tests for widgets and settings, which are dependent upon the refactoring of the plugin
  • ❓ adds Gulp
  • ❌ adds SCSS version of the plugin's CSS

and some other stuff.

Would needs a lot of cleanup before merging.

@benlk benlk mentioned this pull request Oct 23, 2018
Open
@benlk benlk added this to the plugin-boilerplate milestone Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aschweigert aschweigert Awaiting requested review from aschweigert
@rclachance rclachance Awaiting requested review from rclachance

Assignees

No one assigned

Labels

help wanted status: needs docs

Projects

None yet

Milestone

plugin-boilerplate

Development

Successfully merging this pull request may close these issues.

3 participants

@benlk @rclachance @aschweigert