[codex] Stabilize ops and Anki workflows#22
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c41d4a9a54
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!res.ok) { | ||
| return { | ||
| ok: true, | ||
| runtime: runtimeKey, |
There was a problem hiding this comment.
Return failure when runtime status cannot reach Docker
Marking the Docker probe failure as ok: true causes runtime:*:status to exit successfully even when Docker is unavailable (for example, docker missing or permission denied). In that scenario, callers that rely on exit status will treat the runtime check as healthy and skip remediation, despite the status payload already carrying an error. This should propagate as a failed status (ok: false and non-zero exit) so monitoring and scripts can detect the outage reliably.
Useful? React with 👍 / 👎.
Summary
Why
npm testfailed by default.Validation
npm testnpm run -s check:scriptsnpm run -s check:runtime-artifact-trackingnpm audit --omit=devnpm run -s test:changed -- --dry-run --json