Set urls based on market#118
Open
bromiesTM wants to merge 1 commit into
Open
Conversation
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
bromiesTM
force-pushed
the
kh/dev/market-specific-urls
branch
from
1d78f0b to
64766bf
Compare
bromiesTM
changed the title
matsaur
requested changes
Jun 3, 2026
| echo "Configure nc_ionos_processes app" | ||
|
|
||
| if [ -z "${IONOS_PROCESSES_API_URL}" ] || [ -z "${IONOS_PROCESSES_USER}" ] || [ -z "${IONOS_PROCESSES_PASS}" ]; then | ||
| echo "\033[1;33mWarning: IONOS_PROCESSES_API_URL, IONOS_PROCESSES_USER or IONOS_PROCESSES_PASS not set, skipping configuration of nc_ionos_processes app\033[0m" |
There was a problem hiding this comment.
Please "refactor" to use log_warning() here
| echo "Configure serverinfo app" | ||
|
|
||
| if [ -z "${NC_APP_SERVERINFO_TOKEN}" ]; then | ||
| echo "\033[1;33mWarning: NC_APP_SERVERINFO_TOKEN not set, skipping configuration of serverinfo app\033[0m" |
There was a problem hiding this comment.
Please "refactor" to use log_warning() here
There was a problem hiding this comment.
Pull request overview
Adds market-based configuration for IONOS-related URLs by setting Nextcloud system config values during configure.sh execution, and removes previously hardcoded link defaults from the shipped config partial.
Changes:
- Introduce
set_market_links()to select URL targets based onMARKET(FR/DE/ES/UK/IT, defaulting to DE). - Persist the selected URLs into Nextcloud system config via
occ config:system:set, and set the theming “url” accordingly. - Remove static IONOS link entries from
configs/ionos-links.config.phpso they are no longer fixed to a single market.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| configure.sh | Adds market switch logic and writes market-specific links into Nextcloud system config during configuration. |
| configs/ionos-links.config.php | Removes hardcoded market-specific link defaults, leaving only non-market-specific entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+63
to
+68
| IT) | ||
| IONOS_WEBMAIL_TARGET_LINK="https://email.ionos.it/" | ||
| IONOS_HELP_TARGET_LINK="https://wl.hidrive.com/easy/0037" | ||
| IONOS_CUSTOMCLIENT_ANDROID="https://wl.hidrive.com/easy/0033" | ||
| IONOS_CUSTOMCLIENT_IOS="https://wl.hidrive.com/easy/00311" | ||
| IONOS_HOMEPAGE="https://ionos.it/" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.