feat: createBytesSigner for Wallet Standard / @solana/kit / Privy / MPC - #18
Open
NubsCarson wants to merge 1 commit into
Open
feat: createBytesSigner for Wallet Standard / @solana/kit / Privy / MPC #18NubsCarson wants to merge 1 commit into
NubsCarson wants to merge 1 commit into
Conversation
Add a single adapter that converts any bytes-based signer ((Uint8Array) => Promise<Uint8Array>) into the WalletSigner shape the SDK writer methods already accept. Lives in src/sdk/utils/wallet.ts alongside toWalletSigner (Keypair → WalletSigner), so the SDK now covers every signer type in the ecosystem: - Keypair / legacy Signer → toWalletSigner (existing) - wallet-adapter WalletSigner → passed through as-is - Wallet Standard bytes signers → createBytesSigner (new) The bytes primitive is the kit-era canonical signing form. Privy v3's useSignTransaction() hook, MPC services, kit-wrapped standard wallets, and custom backend signers all expose it. No vendor-specific code in the SDK — the helper is one factory function with a generic callback. @solana/kit and @solana/web3.js@^1 are different npm packages and coexist fine; SDK keeps its v1 surface unchanged. README documents usage with Privy as the prototypical example.
NubsCarson
force-pushed
the
feat/bytes-signer
branch
from
April 17, 2026 21:47
47ee45a to
69939ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a single adapter that converts any bytes-based signer ((Uint8Array) => Promise) into the WalletSigner shape the SDK writer methods already accept. Lives in src/sdk/utils/wallet.ts alongside toWalletSigner (Keypair → WalletSigner), so the SDK now covers every signer type in the ecosystem:
The bytes primitive is the kit-era canonical signing form. Privy v3's useSignTransaction() hook, MPC services, kit-wrapped standard wallets, and custom backend signers all expose it. No vendor-specific code in the SDK — the helper is one factory function with a generic callback.
@solana/kit and @solana/web3.js@^1 are different npm packages and coexist fine; SDK keeps its v1 surface unchanged.
README documents usage with Privy as the prototypical example.