11391 display on create with template

[sekmiller]

What this PR does / why we need it: Makes fields set "display on Create" at the Dataverse level visible on dataset create in the presence of a default template for that dataset (especially if the template does not have default values for that Metadata block)

Which issue(s) this PR closes:

• Closes Fields with displayOnCreate setting not visible if collection has a default template #11391
• Closes When a user makes a metadata block's compound fields required, those fields don't appear on the dataset create form and aren't marked as required on the dataset edit form #11421
• Closes Custom metadata block not displaying in dataset creation due to template issue #11214

Special notes for your reviewer: Not sure why the "isDisplayOnCreate" in the Metadata block doesn't work. I added a transient boolean that is updated in the DatasetVersionUI when the metadata blocks are added. Again no clear reason why 11421 stopped working - a test was added to make sure that if a parent dataset field type has required children it will be set to required. Necessary for "display on create" and validation.

Suggestions on how to test this:
Set dataset field types outside of the citation block to "displayOnCreate" for a given Dataverse -

curl -X PUT -H "X-Dataverse-key:27987dd2-8ae1-4b6d-b3f8-78a2ccfcad4d" -H "Content-Type:application/json" "http://localhost:8080/api/dataverses/temp-doc/inputLevels" -d '[{"datasetFieldTypeName":"geographicCoverage", "required":false, "include":true,  "displayOnCreate":true}, {"datasetFieldTypeName":"country", "required":false, "include":true, "displayOnCreate":true}]'

Add a template to the dataset, but don't set default values in the metadata block where you set "displayOnCreate". Make that template the default.

Add a dataset - the dataset fields set as display on create should be available for edit.

Also, you can try it with no default template but select one after "add dataset" - as above, the dataset fields set as display on create should be available for edit.

For 11421 set child fields as "required" and make sure that they are included in "display on create". Also that they must be filled in so that a dataset version is valid.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

[coveralls]

coverage: 23.076% (-0.003%) from 23.079%
when pulling c2ac931 on 11391-displayOnCreate-with-template
into 43547e7 on develop.

[github-actions]

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11391-displayOnCreate-with-template

ghcr.io/gdcc/configbaker:11391-displayOnCreate-with-template

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

[qqmyers]

OK - looks good - thanks for the explanations. As noted, I made a small PR against this one (#11538) that has some suggested cleanup, but this PR works as is, so I'll approve and let you decide whether to merge the other one.

FWIW: I did do some testing on this following the testing instructions to set displayOnCreate for some geo block fields - and verified that I see the geo block when there's no template, when there's a default template, and when you select a non-default template.

[qqmyers]

You understand the difference better than I do, but I was mostly talking about a mechanical refactor. I made a quick PR against this branch with a refactor to drop the separate variable and reduce duplicate code. It shouldn't change functionality at all.

[qqmyers]

Got it - I still wonder a bit about the order of those lines, but digging some more I realized why shouldDisplayOnCreate can't work in the MetadataBlock.isDisplayOnCreate call - the fieldTypes being checked there are straight from the db and not the ones from the workingVersion datasetfield.getDatasetFieldType list which has been localized to the local collection. Given that - it's clear why your solution is needed - the metadatablock localDisplayOnCreate has to be set by checking the localized field types from the working version, which is what the code in DatasetVersionUI does.
In the small PR I made against this one, I tried to edit the comments and did a little cleanup to avoid double looping. - I made comments in the PR about it.

[ofahimIQSS]

Adding testing evidences below:

**

**

Looks good to me - merging