Skip to content

Added a control to publishing a Dataset and cleaning dataversesubjects table#11551

Merged
ofahimIQSS merged 5 commits into
IQSS:developfrom
Recherche-Data-Gouv:11536-Inconsistency-between-subject-metrics-for-dataverses-and-datasets
Aug 21, 2025
Merged

Added a control to publishing a Dataset and cleaning dataversesubjects table#11551
ofahimIQSS merged 5 commits into
IQSS:developfrom
Recherche-Data-Gouv:11536-Inconsistency-between-subject-metrics-for-dataverses-and-datasets

Conversation

@stevenferey
Copy link
Copy Markdown
Contributor

Added a control to publishing a Dataset and cleaning the dataverses sujects table having a controlledvocabularyvalue_id corresponding to N/A

What this PR does / why we need it:

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

…jects table having a controlledvocabularyvalue_id corresponding to N/A
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 23.145%. remained the same
when pulling 1de2bbf on Recherche-Data-Gouv:11536-Inconsistency-between-subject-metrics-for-dataverses-and-datasets
into 54af71e on IQSS:develop.

@pdurbin pdurbin moved this to Ready for Triage in IQSS Dataverse Project Jun 16, 2025
@ofahimIQSS ofahimIQSS added Size: 3 A percentage of a sprint. 2.1 hours. labels Jun 17, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for Triage to Ready for Review ⏩ in IQSS Dataverse Project Jun 17, 2025
@cmbz cmbz added FY25 Sprint 25 FY25 Sprint 25 (2025-06-04 - 2025-06-18) FY25 Sprint 26 FY25 Sprint 26 (2025-06-18 - 2025-07-02) labels Jun 18, 2025
@cmbz cmbz added the FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) label Jul 2, 2025
@sekmiller
Copy link
Copy Markdown
Contributor

@stevenferey There are merge conflicts and, unfortunately this will not make it into version 6.7 of dataverse, so please update the sql script name. Thanks!

@jeromeroucou jeromeroucou moved this to 🚧 Dev by Recherche Data Gouv in Recherche Data Gouv Jul 16, 2025
@sekmiller sekmiller self-assigned this Jul 16, 2025
@sekmiller sekmiller moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Jul 16, 2025
Copy link
Copy Markdown
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The sql script is written for a post-6.7 merge.

@github-project-automation github-project-automation Bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Jul 16, 2025
@sekmiller sekmiller removed their assignment Jul 16, 2025
@cmbz cmbz added the FY26 Sprint 2 FY26 Sprint 2 (2025-07-16 - 2025-07-30) label Jul 17, 2025
@ofahimIQSS
Copy link
Copy Markdown
Contributor

Hello! Can you bump the version in pom.xml to 6.7 please? Thanks!

@cmbz cmbz added the FY26 Sprint 3 (2025-07-30 - 2025-08-13) label Jul 31, 2025
@cmbz cmbz added the FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) label Aug 14, 2025
@ofahimIQSS ofahimIQSS added the Status: Needs Input Applied to issues in need of input from someone currently unavailable label Aug 19, 2025
@pdurbin
Copy link
Copy Markdown
Member

pdurbin commented Aug 20, 2025

Hello! Can you bump the version in pom.xml to 6.7 please? Thanks!

Done. I just merged the latest from develop.

@pdurbin pdurbin removed the Status: Needs Input Applied to issues in need of input from someone currently unavailable label Aug 20, 2025
@ofahimIQSS ofahimIQSS self-assigned this Aug 20, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Aug 20, 2025
@ofahimIQSS ofahimIQSS merged commit 449c2f7 into IQSS:develop Aug 21, 2025
14 checks passed
@github-project-automation github-project-automation Bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Aug 21, 2025
@github-project-automation github-project-automation Bot moved this from 🚧 Dev by Recherche Data Gouv to Done in Recherche Data Gouv Aug 21, 2025
@ofahimIQSS ofahimIQSS removed their assignment Aug 21, 2025
@pdurbin pdurbin added this to the 6.8 milestone Aug 21, 2025
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been called V6.7.1.2.sql

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevenferey we had to revert this in PR #11759 because the Flyway script had the wrong name. Can you please create a fresh PR? Thanks!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pdurbin, I just created PR #11765 .
I hope this works. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 25 FY25 Sprint 25 (2025-06-04 - 2025-06-18) FY25 Sprint 26 FY25 Sprint 26 (2025-06-18 - 2025-07-02) FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) FY26 Sprint 2 FY26 Sprint 2 (2025-07-16 - 2025-07-30) FY26 Sprint 3 (2025-07-30 - 2025-08-13) FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) Size: 3 A percentage of a sprint. 2.1 hours.

Projects

Status: Done 🧹
Status: Done

Development

Successfully merging this pull request may close these issues.

Inconsistency between subject metrics for dataverses and datasets

8 participants