-
Notifications
You must be signed in to change notification settings - Fork 543
Notifications API extension and new notifications generated by API operations #11696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
3f9ada4
Refactor: Notifications.getAllNotificationsForUser high level clean up
GPortas fc1ad89
Refactor: moved response payload generation logic from getAllNotifica…
GPortas 95a53d4
Refactor: using same Bundle string on common responses in Notificatio…
GPortas 63a7753
Stash: inAppNotificationFormat option in getAllNotificationsForUser WIP
GPortas c65a20f
Removed: MailServiceBean from Notifications
GPortas 7abb5fa
Removed: unused method getReasonsForReturn
GPortas b4313ae
Added: InAppNotificationsJsonPrinter for adding the necessary fields …
GPortas a3ce057
Stash: replicating JSF notifications data in InAppNotificationsJsonPr…
GPortas 345a0af
Added: ASSIGNROLE Dataverse notification to InAppNotificationsJsonPri…
GPortas acff848
Added: InAppNotificationsJsonPrinter logic for ASSIGNROLE, REVOKEROLE…
GPortas 503b20e
Merge branch 'develop' of github.com:IQSS/dataverse into 11648-notifi…
GPortas 12ef731
Refactor: new method addCreateAccountFields extracted in InAppNotific…
GPortas 5d6e00a
Added: addFieldsByType logic for REQUESTFILEACCESS and REQUESTEDFILEA…
GPortas e199bf1
Added: addFieldsByType logic for GRANTFILEACCESS and REJECTFILEACCESS…
GPortas edfdac2
Added: addFieldsByType logic for DATASETCREATED to InAppNotifications…
GPortas a247df0
Added: tweaks and fixes to InAppNotificationsJsonPrinter
GPortas 83e32fc
Added: notifications and tweaks to InAppNotificationsJsonPrinter
GPortas c8f93ff
Refactor: InAppNotificationsJsonPrinter
GPortas aa6ba8c
Stash: InAppNotificationsJsonPrinterTest WIP
GPortas fb61d37
Fixed: InAppNotificationsJsonPrinterTest
GPortas 1fcad70
Merge branch 'develop' of github.com:IQSS/dataverse into 11648-notifi…
GPortas 15ee5b1
Fixed: JsonPrinter new dependencies injection
GPortas 052f886
Changed: enhanced CreateNewDatasetCommand to allow self notifications…
GPortas 7d341d7
Added: sending notification when a dataset is created through the /da…
GPortas 3f101d3
Added: NotificationsIT case when SendNotificationOnDatasetCreation se…
GPortas a5e1a08
Added: user notification sent when running addDataverse endpoint
GPortas b57d8a4
Merge branch 'develop' of github.com:IQSS/dataverse into 11648-notifi…
GPortas d99324d
Added: NotificationsIT test cases for inAppNotificationFormat query p…
GPortas 974cd1a
Added: missing assertions to NotificationsIT
GPortas 2b8d600
Added: docs for #11648
GPortas 57f3d99
Added: doc format tweak
GPortas e4b921e
Added: docs for #11648
GPortas 9a5b3d0
Added: API section param to notifications payload
GPortas 183ce1c
Merge branch 'develop' of github.com:IQSS/dataverse into 11648-notifi…
GPortas af54086
Added: disabling SendNotificationOnDatasetCreation after IT test
GPortas 56b2207
Fixed: NPE exception on notifications API when a dataverse has no owner
GPortas 5fda593
Added: tweak to notifications API docs
GPortas daa4e3f
Fixed: CREATEDS not returning expected fields
GPortas 21ab283
Added: guide section param to INGESTCOMPLETED notif payload
GPortas e76a366
Added: sending new objectDeleted field when the object of the notific…
GPortas e1ec2f8
Update doc/release-notes/11648-notifications-api-extension.md
GPortas 99514ab
Fixed: InReviewWorkflowIT
GPortas e83ceb8
Merge branch '11648-notifications-api-extension' of github.com:IQSS/d…
GPortas ddd29ab
Refactor: always using getRequestAuthenticatedUserOrDie in Notificati…
GPortas 3f4cc64
Refactor: use enum toString instead of hardcoded strings in Notificat…
GPortas 4b98088
Refactor: use enum toString instead of hardcoded strings in InReviewW…
GPortas 18e78c7
Removed: unused throws in test
GPortas d3126f0
Changed: using BeforeAll and AfterAll in NotificationsIT with disable…
GPortas 5618740
Refactor: renamed CreateNewDatasetCommand variable
GPortas 03c3a8a
Added: installationName param to CREATEACC notification In-App payload
GPortas dd3a695
Merge branch 'develop' of github.com:IQSS/dataverse into 11648-notifi…
GPortas ee3f605
Removed: 'v' prefix from guides version number in InApp notifications…
GPortas 3966a3c
Fixed: updated unit test for InApp notifications
GPortas e6f4221
Added: javadocs for CreateDataverseCommand.onSuccess method
GPortas db953d0
Added: explanatory comment to PermissionServiceBean.getEffectiveRoleA…
GPortas f1dea35
Removed: language path param from guides URL in returned InApp notifi…
GPortas c38aeac
Changed: installationBrandName param relying on BrandingUtils
GPortas e1b4551
Removed: method for removing 'v' from guides viersion in InAppNotific…
GPortas 877e428
Merge branch 'develop' of github.com:IQSS/dataverse into 11648-notifi…
GPortas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # getAllNotificationsForUser API extension | ||
|
|
||
| - Extended endpoint getAllNotificationsForUser(``/notifications/all``), which now supports an optional query parameter ``inAppNotificationFormat`` which, if sent as ``true``, retrieves the fields needed to build the in-app notifications for the Notifications section of the Dataverse UI, omitting fields related to email notifications. See also #11648 and #11696. | ||
|
|
||
| # Notifications triggered by API endpoints | ||
|
|
||
| The addDataset and addDataverse API endpoints now trigger user notifications upon successful execution. See also #1342 and #11696. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.