DD-1988 - Fix /api/admin/validate/dataset/files/{id} error response#11749
Merged
ofahimIQSS merged 1 commit intoAug 27, 2025
Conversation
ofahimIQSS
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
sekmiller
approved these changes
Aug 20, 2025
github-project-automation
Bot
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
fix looks good, now getting 404 vs 500 response for invalid PIDs. |
github-project-automation
Bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
aliassheikh
added a commit
to DANS-KNAW/dataverse
that referenced
this pull request
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: As reported internally at DANS (DD-1988), when the /api/admin/validate/dataset/files/{id} API call is called with a non-existent PID/id, the error response is 500 rather than 404. This PR corrects that.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Call the api above with a made up PID/id, verify that it produces a 500 error before and a 404 error after the PR.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: