Skip to content

External Tools research#11755

Closed
g-saracca wants to merge 1 commit into
developfrom
research-ext-tools
Closed

External Tools research#11755
g-saracca wants to merge 1 commit into
developfrom
research-ext-tools

Conversation

@g-saracca
Copy link
Copy Markdown
Contributor

@g-saracca g-saracca commented Aug 20, 2025

What this PR does / why we need it:
Draft PR only for Testing using the GHCR generated image

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@g-saracca g-saracca changed the title Draft PR only for Testing using the GHCR generated image External Tools research Aug 20, 2025
@github-actions
Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:research-ext-tools
ghcr.io/gdcc/configbaker:research-ext-tools

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@qqmyers
Copy link
Copy Markdown
Member

qqmyers commented Aug 20, 2025

I understand this is a draft PR for testing. FWIW: for production use, I think it would be better to split getting the listing of tools from getting the signed URLs, as we do now. A lot depends on whether the tools remain separate apps - if they aren't, they may not need signed URLs (but we would loose the ability to control what they can do if they can just use the SPA authentication.) Currently a tool is launched by giving it one short-lived signed URL as a base64-encoded token and it calls that to get all of the params and (potentially longer-lived) signed URLs its configured for, but all of this happens only when a tool is run, not when the initial listing of tools is shown.

@g-saracca
Copy link
Copy Markdown
Contributor Author

I understand this is a draft PR for testing. FWIW: for production use, I think it would be better to split getting the listing of tools from getting the signed URLs, as we do now. A lot depends on whether the tools remain separate apps - if they aren't, they may not need signed URLs (but we would loose the ability to control what they can do if they can just use the SPA authentication.) Currently a tool is launched by giving it one short-lived signed URL as a base64-encoded token and it calls that to get all of the params and (potentially longer-lived) signed URLs its configured for, but all of this happens only when a tool is run, not when the initial listing of tools is shown.

Thanks Jim, I understand. I think I could use the already existing api endpoint to get all the available tools and then we could create a new endpoint to get the final url processed by the backend logic? But this last part only happening when the tool (iframe) is in view and not before?
Right now we need to support the File previewers.

@g-saracca g-saracca closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants