Skip to content

split AnonymizedFieldTypeNames#11811

Merged
stevenwinship merged 1 commit into
IQSS:developfrom
DANS-KNAW-jp:split-AnonymizedFieldTypeNames
Nov 7, 2025
Merged

split AnonymizedFieldTypeNames#11811
stevenwinship merged 1 commit into
IQSS:developfrom
DANS-KNAW-jp:split-AnonymizedFieldTypeNames

Conversation

@jo-pol
Copy link
Copy Markdown
Contributor

@jo-pol jo-pol commented Sep 11, 2025

What this PR does / why we need it:

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer:

Suggestions on how to test this:

  • Set the database setting like this (note the comma's without spaces):

curl -X PUT -d "author,datasetContact,contributor,depositor,grantNumber,publication,distributor,producer" http://localhost:8080/api/admin/settings/:AnonymizedFieldTypeNames

  • Create a draft dataset and request an anonymized preview URL.
  • Log out
  • Try the URL

Before applying the change, no fields are withheld, after the deploy fields, we get the expected behavior

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@jo-pol jo-pol changed the title split on comma between optional whitespace split AnonymizedFieldTypeNames Sep 11, 2025
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 23.552%. remained the same
when pulling 9008d56 on DANS-KNAW-jp:split-AnonymizedFieldTypeNames
into 195a584 on IQSS:develop.

@pdurbin pdurbin moved this to Ready for Triage in IQSS Dataverse Project Sep 11, 2025
@qqmyers qqmyers added the Size: 3 A percentage of a sprint. 2.1 hours. label Sep 11, 2025
@qqmyers qqmyers added this to the 6.9 milestone Sep 11, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for Triage to Ready for QA ⏩ in IQSS Dataverse Project Sep 16, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to Ready for Review ⏩ in IQSS Dataverse Project Sep 16, 2025
@cmbz cmbz added FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) labels Sep 24, 2025
@cmbz cmbz added the FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) label Oct 8, 2025
@cmbz cmbz added the FY26 Sprint 9 FY26 Sprint 9 (2025-10-22 - 2025-11-05) label Oct 23, 2025
aliassheikh added a commit to DANS-KNAW/dataverse that referenced this pull request Oct 23, 2025
Copy link
Copy Markdown
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Needs to be tested.

@github-project-automation github-project-automation Bot moved this from Ready for Review ⏩ to Ready for QA ⏩ in IQSS Dataverse Project Oct 24, 2025
@ofahimIQSS ofahimIQSS self-assigned this Oct 24, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Oct 24, 2025
@cmbz cmbz moved this from QA ✅ to Ready for QA ⏩ in IQSS Dataverse Project Nov 5, 2025
@cmbz cmbz added the FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) label Nov 5, 2025
@stevenwinship stevenwinship self-assigned this Nov 7, 2025
@stevenwinship stevenwinship moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Nov 7, 2025
@stevenwinship
Copy link
Copy Markdown
Contributor

stevenwinship commented Nov 7, 2025

Without fix:

image

With fix:

image

@stevenwinship
Copy link
Copy Markdown
Contributor

stevenwinship commented Nov 7, 2025

RE: Set the database setting like this (note the comma's without spaces)

I tested with both spaces author, datasetContact,... and no spaces author,datasetContact,...
Both were successful.

@stevenwinship stevenwinship merged commit c6ccf87 into IQSS:develop Nov 7, 2025
15 checks passed
@github-project-automation github-project-automation Bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Nov 7, 2025
@stevenwinship stevenwinship removed their assignment Nov 7, 2025
@jo-pol
Copy link
Copy Markdown
Contributor Author

jo-pol commented Nov 10, 2025

Without pointing at anyone specific, there seems to be some miscommunication. The issue was also tackled by the still open #11745 this merge causes merge conflicts.

@stevenwinship
Copy link
Copy Markdown
Contributor

@jo-pol Would you like this merge reverted?

@jo-pol
Copy link
Copy Markdown
Contributor Author

jo-pol commented Nov 10, 2025

@jo-pol Would you like this merge reverted?

No, @qqmyers explained this was to be sure to get it in v6.9 and give me credits.

@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) FY26 Sprint 8 FY26 Sprint 8 (2025-10-08 - 2025-10-22) FY26 Sprint 9 FY26 Sprint 9 (2025-10-22 - 2025-11-05) FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) Size: 3 A percentage of a sprint. 2.1 hours.

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

8 participants