Inconsistent behaviour of dataset delete API#12332
Open
stevenwinship wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
FY26 Sprint 21
|
coverage: 24.951% (+0.001%) from 24.95% — 11253-inconsistent-dataset-delete-api into develop |
This comment has been minimized.
This comment has been minimized.
stevenwinship
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
stevenwinship
force-pushed
the
11253-inconsistent-dataset-delete-api
branch
from
753818d to
153ec4c
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11253-inconsistent-dataset-delete-api
branch
from
153ec4c to
09a31f7
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11253-inconsistent-dataset-delete-api
branch
from
09a31f7 to
f83ba61
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11253-inconsistent-dataset-delete-api
branch
2 times, most recently
from
106b4dc to
7a441b4
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11253-inconsistent-dataset-delete-api
branch
from
7a441b4 to
b0124fb
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11253-inconsistent-dataset-delete-api
branch
from
b0124fb to
81859f7
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11253-inconsistent-dataset-delete-api
branch
from
81859f7 to
fbe0852
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11253-inconsistent-dataset-delete-api
branch
from
fbe0852 to
72bf6b7
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11253-inconsistent-dataset-delete-api
branch
from
72bf6b7 to
d178e60
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11253-inconsistent-dataset-delete-api
branch
from
d178e60 to
1427ae3
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11253-inconsistent-dataset-delete-api
branch
from
1427ae3 to
b5193a0
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11253-inconsistent-dataset-delete-api
branch
from
b5193a0 to
f1ebfaf
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11253-inconsistent-dataset-delete-api
branch
from
f1ebfaf to
555ab41
Compare
This comment has been minimized.
This comment has been minimized.
sekmiller
reviewed
May 21, 2026
sekmiller
previously requested changes
May 21, 2026
Contributor
sekmiller
left a comment
sekmiller
left a comment
There was a problem hiding this comment.
Minor change suggestion - change the name of the permissions wrapper method to reflect the command tested. (it's only called in a couple of places)
stevenwinship
force-pushed
the
11253-inconsistent-dataset-delete-api
branch
from
555ab41 to
a87465a
Compare
This comment has been minimized.
This comment has been minimized.
sekmiller
approved these changes
May 22, 2026
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
stevenwinship
force-pushed
the
11253-inconsistent-dataset-delete-api
branch
from
a87465a to
59d7049
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11253-inconsistent-dataset-delete-api
branch
from
59d7049 to
b70465c
Compare
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: API call of delete Dataset does not match what has been documented. Superuser must use /destroy to delete a released Dataset. Delete Dataset API should only work for "Draft" datasets.
Which issue(s) this PR closes: #11253
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: Included
Additional documentation: