Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Brian, Zhenyi, David,
In an earlier PR, I had shared a script (
fullSimulation.m) that emulated the complete EXR-to-image pipeline stage-by-stage.During experiments that followed, I realised that the script was focused on the OVT split-pixel DCG, while ISETHDR has a broader scope. So I renamed it to
s_OmnivFullSim.mindicating the same, following the repo's naming convention.Furthermore, I have added features that I had discovered in ISETCam along the way, like -- denoising and white balance. Added more comments to explain what's happening in each stage based on my understanding.
I hope this improvement in the full simulator for the OVT sensor will help the reader understand the functioning of all stages in one place.
Thanks,
Ayush