Use bundled jdk to compile#1856
Open
FreddieAkeroyd wants to merge 1 commit into
Open
Conversation
| @@ -7,7 +7,7 @@ set M2=%MAVEN%bin | |||
Member
There was a problem hiding this comment.
I think this %MAVEN% variable is no longer set, when I look at a jenkins log the path is:
set "PATH=C:\jenkins\workspace\ibex_gui_pr_pipeline_PR-1856\build\jdk\bin;bin;C:\TwinCAT\Common64;...
I think that standalone bin is because %MAVEN% was blank
Member
Author
There was a problem hiding this comment.
yes, i've moved this and setting of M2 to the other files. Wasn't sure of we need M2_HOME / MAVEN_HOME too?
FreddieAkeroyd
force-pushed
the
ensure_jdk_version
branch
from
6da9cf8 to
aa8a648
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Use bundled JDK to compile client - previously it was picking up whatever java was in system PATH. Using bundled jdk ensures correct version is always used and also consistency across build servers
Acceptance criteria
Code Review
check_opi_format.pyscript in C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis pass?Final Steps