Skip to content

Added function remove_value to HashMapContext - #189

Merged
ISibboI merged 5 commits into
ISibboI:mainfrom
sudodios:main
Oct 29, 2025
Merged

Added function remove_value to HashMapContext#189
ISibboI merged 5 commits into
ISibboI:mainfrom
sudodios:main

Conversation

@sudodios

Copy link
Copy Markdown
Contributor

Implements a new method to remove variables from context maps.
Returns the removed Value if present, or None otherwise.
Includes corresponding unit test for verification.


@ISibboI

ISibboI commented Oct 29, 2025

Copy link
Copy Markdown
Owner

Thanks! Could you make the CI tests pass?

@sudodios

Copy link
Copy Markdown
Contributor Author

Oh, yes, definitely.

@sudodios

Copy link
Copy Markdown
Contributor Author

Coverage requires that the default body be tested as well.
Is it necessary?

@sebschmi

Copy link
Copy Markdown

Nah it's fine. Thanks for the contribution!

@sebschmi sebschmi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things, would be great if you could fix them.

Comment thread src/context/mod.rs
Comment thread src/context/mod.rs
Comment thread tests/integration.rs
Comment thread tests/integration.rs

@ISibboI ISibboI left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@ISibboI
ISibboI merged commit 75d9740 into ISibboI:main Oct 29, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants