feat: add URL links to all GitHub event notifications#7
Open
IYENTeam wants to merge 1 commit into
Open
Conversation
- Add url field to IssueSnapshot and GitHubIssue structs - Pass html_url through issue-opened/commented/closed events - Render URL in PR status-changed (Compact/Alert/Inline formats) - Render URL in issue-opened/commented/closed (all formats) - CI events already included URLs, no change needed - Update CLI IssueOpened command to accept --url flag - Update webhook handler to extract issue html_url - Fix all tests for new url parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add clickable URL links to all GitHub event notifications that were missing them.
Problem
PR status-changed and issue events (opened/commented/closed) were rendered without links, making it impossible to click through to the actual GitHub page from Discord notifications. CI events already had URLs.
Changes
src/source/github.rsurlfield toIssueSnapshot,html_urltoGitHubIssuestruct, pass through to eventssrc/events.rsurl: Stringparameter togithub_issue_opened/commented/closedconstructorssrc/render/default.rssrc/daemon.rs/issue/html_urlfrom webhook payloadsrc/cli.rs--urlflag toIssueOpenedCLI commandsrc/main.rsurlthrough CLI dispatchsrc/router.rsBefore/After
Verification
cargo check: ✅ cleancargo test: ✅ all passed