This repository was archived by the owner on Jul 27, 2020. It is now read-only.
Fixes an offset-bug on pages that use multiple parallax images#14
Open
fjenett wants to merge 3 commits intoIanLunn:masterfrom
fjenett:master
Open
Fixes an offset-bug on pages that use multiple parallax images#14fjenett wants to merge 3 commits intoIanLunn:masterfrom fjenett:master
fjenett wants to merge 3 commits intoIanLunn:masterfrom
fjenett:master
Conversation
As per API definition offset() returns the position of the FIRST element, using $this will cause to return always the same value.
The `firstTop` variable stores the top of the first element only, should instead store per element.
$e should have been $element; removed unused firstTop variable; renamed $e to $element
|
Hi, The script seems to center horizontally and position the background vertically to the top. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the script stores only the offset().top of the first element matched by jQuery, it should instead store top for every element.