This repository was archived by the owner on Jul 27, 2020. It is now read-only.
Make plugin AMD compatible, preserves initial background vertical position, misc. updates and optimizations#8
Open
jhummel wants to merge 16 commits intoIanLunn:masterfrom
Open
Make plugin AMD compatible, preserves initial background vertical position, misc. updates and optimizations#8jhummel wants to merge 16 commits intoIanLunn:masterfrom
jhummel wants to merge 16 commits intoIanLunn:masterfrom
Conversation
added 16 commits
August 22, 2013 09:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds AMD compatibility. (Also works fine if not using AMD). Preserves initial vertical position of the background - so you can start with a background position of '50% -100px', for instance. (y pos always assumes pixels). Updates the demo css to highlight this capability. Added a gitignore file and removed .DS_Store from repo. Optimized script by removing unneeded jquery calls and loops. Returns jQuery object to allow for chaining.