Skip to content

notifications: drop obsolete event fields & introduce new ones#199

Merged
yhabteab merged 2 commits into
developfrom
notifications-v1
May 21, 2026
Merged

notifications: drop obsolete event fields & introduce new ones#199
yhabteab merged 2 commits into
developfrom
notifications-v1

Conversation

@yhabteab
Copy link
Copy Markdown
Member

@yhabteab yhabteab commented Apr 30, 2026

Warning

This PR is not yet part of the main branch since it introduces a breaking change to the notifications package and all its users must be fixed first before merging this into the main branch (See the failing GHAs below).

This PR drops the obsolete extra_tags, rule_ids, and rules_version fields from the notification Event struct as they are no longer used by Icinga Notifications since Icinga/icinga-notifications#418. It also introduces two new fields complete_relations and relations to the Event struct, which are going to be used by the new Notifications rule evaluation engine to determine which rules match a given event. Additionally, it adds a new HTTP header X-Icinga-Reject-If-Relations-Incomplete to be used by the Notifications API to indicate whether the client supports attribute negotiation. The name of the header is not final and is open for discussion.

@yhabteab yhabteab requested a review from oxzi April 30, 2026 12:46
@cla-bot cla-bot Bot added the cla/signed CLA is signed by all contributors of a PR label Apr 30, 2026
@oxzi
Copy link
Copy Markdown
Member

oxzi commented Apr 30, 2026

While I am generally okay with this change, the failing compatibility CI jobs underline a certain question: Do we want to merge this directly into main and temporarily breaking compatibility with the downstream consumers or do we want to work with a feature branch to merge things into before merging it all back to main?

@yhabteab
Copy link
Copy Markdown
Member Author

Just in case we need to release IGL in the meantime without such changes, we can also use a separate branch till all the consumers are adapted to these changes as well.

@yhabteab yhabteab changed the base branch from main to develop April 30, 2026 14:20
@yhabteab
Copy link
Copy Markdown
Member Author

I've changed the base branch now.

oxzi
oxzi previously approved these changes May 4, 2026
@oxzi oxzi added this to the notifications-v1.0 milestone May 4, 2026
@yhabteab
Copy link
Copy Markdown
Member Author

After a short discussion with @nilmerg offline, we agreed to rename the HTTP header to X-Icinga-Reject-If-Relations-Incomplete to reflect its usage correctly, so I've updated the PR accordingly.

@yhabteab yhabteab requested a review from oxzi May 12, 2026 15:14
@yhabteab yhabteab merged commit a12c30a into develop May 21, 2026
16 of 19 checks passed
@yhabteab yhabteab deleted the notifications-v1 branch May 21, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants